Add support for parameter store authentication #7572
+126,906
−36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -102,6 +102,9 @@ type TriggerAuthenticationSpec struct { | |
| // +optional | ||
| AwsSecretManager *AwsSecretManager `json:"awsSecretManager,omitempty"` | ||
|
|
||
| // +optional | ||
| AwsParameterStore *AwsParameterStore `json:"awsParameterStore,omitempty"` | ||
|
|
||
| // +optional | ||
| BoundServiceAccountToken []BoundServiceAccountToken `json:"boundServiceAccountToken,omitempty"` | ||
| } | ||
|
|
@@ -398,6 +401,40 @@ type AwsSecretManagerSecret struct { | |
| SecretKey string `json:"secretKey,omitempty"` | ||
| } | ||
|
|
||
| // AwsParameterStore is used to authenticate using AWS Systems Manager Parameter Store | ||
| type AwsParameterStore struct { | ||
| // +kubebuilder:validation:MinItems=1 | ||
| Parameters []AwsParameterStoreParameter `json:"parameters"` | ||
| // +optional | ||
| Credentials *AwsParameterStoreCredentials `json:"credentials"` | ||
| // +optional | ||
| PodIdentity *AuthPodIdentity `json:"podIdentity"` | ||
|
Member
There was a problem hiding this comment. Should
Author
There was a problem hiding this comment. I believe omitempty isn't needed for pointers, same pattern is used for here |
||
| // +optional | ||
| Region string `json:"region,omitempty"` | ||
| } | ||
|
|
||
| type AwsParameterStoreCredentials struct { | ||
| AccessKey *AwsParameterStoreValue `json:"accessKey"` | ||
| AccessSecretKey *AwsParameterStoreValue `json:"accessSecretKey"` | ||
| // +optional | ||
| AccessToken *AwsParameterStoreValue `json:"accessToken,omitempty"` | ||
| } | ||
|
|
||
| type AwsParameterStoreValue struct { | ||
| ValueFrom ValueFromSecret `json:"valueFrom"` | ||
| } | ||
|
|
||
| // WithDecryption defaults to true if not specified. | ||
| // For SecureString parameters, this must be true to retrieve the plaintext value. | ||
| // Set to false for SecureString parameters to retrieve the encrypted value. | ||
| // For String parameters, this setting has no effect. | ||
| type AwsParameterStoreParameter struct { | ||
| Parameter string `json:"parameter"` | ||
| Name string `json:"name"` | ||
| // +optional | ||
| WithDecryption *bool `json:"withDecryption,omitempty"` | ||
|
Member
There was a problem hiding this comment. Can you add here a comment to clarify what omitting WithDecryption (leaving it nil) means? Users likely need to set this to true to get the plaintext, right? |
||
| } | ||
|
|
||
| type BoundServiceAccountToken struct { | ||
| Parameter string `json:"parameter"` | ||
| ServiceAccountName string `json:"serviceAccountName"` | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should
omitemptyappear here too?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe
omitemptyisn't needed for pointers, same pattern is used for hereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include the line number in the reference, so I can check exactly which one you mean?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops sorry I thought I had, here it is https://github.com/stegojulia/keda/blob/3a66e4f91dbd340a4e06b262f5cd6396c325373b/apis/keda/v1alpha1/triggerauthentication_types.go#L409
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, check. I only know that part from the API convention for using that:
https://github.com/kubernetes/community/blob/main/contributors/devel/sig-architecture/api-conventions.md?plain=1#L841