Implementation of Safari Web Extension and communication with KeePassXC.#2443
Closed
sebastianlivoni wants to merge 13 commits intokeepassxreboot:developfrom
Closed
Implementation of Safari Web Extension and communication with KeePassXC.#2443sebastianlivoni wants to merge 13 commits intokeepassxreboot:developfrom
sebastianlivoni wants to merge 13 commits intokeepassxreboot:developfrom
Conversation
varjolintu
reviewed
Jan 27, 2025
varjolintu
reviewed
Jan 27, 2025
Author
varjolintu
reviewed
Jan 28, 2025
varjolintu
reviewed
Jan 28, 2025
varjolintu
reviewed
Jan 28, 2025
varjolintu
reviewed
Jan 28, 2025
2f2f72b to
db53358
Compare
Author
|
I think it is ready for some testing. |
Member
|
Uh oh was that an accident? |
Author
|
Yes that was an accident... I wanted to delete some other local branches... |
Member
|
I'll review this soon. Sorry for the delay! |
Author
|
Closed in favor of keepassxreboot/keepassxc#12002 and #2509 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


With continuation of work from pull request #1035 and issue #294, I've added the ability for KeePassXC to communicate with the Safari Web Extension. Messages are sent from KeePassXC to the Web Extension and vice versa.
The solution requires that KeePassXC saves the socket to
~/Library/Group Containers/G2S7P7J672.org.keepassxc.KeePassXC/KeePassXC.BrowserServerand adds the app group entitlement forG2S7P7J672.org.keepassxc.KeePassXC.Changes:
context.completeRequestwas removed, andSFSafariApplication.dispatchMessageis now used instead.The app MUST be distributed through the macOS App Store requiring a Apple Developer Account (99 USD each year).
Screenshots or videos
Testing strategy
I've made visual testing checking whether images are correctly loaded for Safari Web Extension and tried to use the extension on multiple websites including autofilling and lock / unlock of database.
In order to test this, make sure to use a build of KeePassXC that saves the socket to
~/Library/Group Containers/G2S7P7J672.org.keepassxc.KeePassXC/KeePassXC.BrowserServerType of change