Force credentials extraction upon manual request

[a2kolbasov]

(continuing of #2767 (comment))

This function is blocked by the autoRetrieveCredentials setting. If the user turned it off, then manually requested credentials, and then changed something in the database, he does not have the opportunity to request them again without updating the page.

An option like

if ((kpxc.settings.autoRetrieveCredentials || force) && kpxc.url && kpxc.submitUrl) {

is not suitable. It is necessary to separate the desire not to use the cache from the user's explicit request.

kpxc.retrieveCredentials(true)

also called here:

keepassxc-browser/keepassxc-browser/content/banner.js

Lines 370 to 384 in 8c3df94

	kpxcBanner.verifyResult = async function(code) {
	if (code === 'error') {
	kpxcUI.createNotification('error', tr('rememberErrorCannotSaveCredentials'));
	} else if (code === 'created') {
	kpxcUI.createNotification(
	'success',
	tr('rememberCredentialsSaved', kpxcBanner.credentials.username || tr('rememberEmptyUsername')),
	);
	await kpxc.retrieveCredentials(true); // Forced reload
	} else if (code === 'updated') {
	kpxcUI.createNotification(
	'success',
	tr('rememberCredentialsUpdated', kpxcBanner.credentials.username || tr('rememberEmptyUsername')),
	);
	await kpxc.retrieveCredentials(true); // Forced reload

If a user saves new credentials, this does not mean that he wants to automatically retrieve them from the database again afterwards (and see a request from the KeePassXC-desktop).

Screenshots or videos

Testing strategy

Manually

Type of change

• ✅ Bug fix (non-breaking change that fixes an issue)

[varjolintu]

If a user saves new credentials, this does not mean that he wants to automatically retrieve them from the database again afterwards (and see a request from the KeePassXC-desktop).

Actually this is something we want to do. Any added or updated credentials should be retrieved from the database.

[a2kolbasov]

Actually this is something we want to do. Any added or updated credentials should be retrieved from the database.

Maybe in this case, we should change the business logic: when updating data, first clear the cache, and then request passwords from the database as if the user had refreshed the page? In this case, users with autoRetrieveCredentials = false will simply remain without cached passwords and (if they need them) will explicitly request them again. And those who only want to update their password will not see the "Confirm Access Dialog" from KeePassXC-desktop.