Skip to content

Force credentials extraction upon manual request #2809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
a2kolbasov wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Force credentials extraction upon manual request #2809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions keepassxc-browser/content/keepassxc-browser.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,17 +648,17 @@ kpxc.rememberCredentialsFromContextMenu = async function() {

// The basic function for retrieving credentials from KeePassXC.
// Credential Banner can force the retrieval for reloading new/modified credentials.
kpxc.retrieveCredentials = async function(force = false) {
kpxc.retrieveCredentials = async function(notFromCache = false, ignoreAutoRetrieveSetting = false) {
if (!await isIframeAllowed()) {
return;
}

kpxc.url = document.location.href;
kpxc.submitUrl = kpxc.getFormActionUrl(kpxc.combinations[0]);

if (kpxc.settings.autoRetrieveCredentials && kpxc.url && kpxc.submitUrl) {
if ((kpxc.settings.autoRetrieveCredentials || ignoreAutoRetrieveSetting) && kpxc.url && kpxc.submitUrl) {
await kpxc.retrieveCredentialsCallback(
await sendMessage('retrieve_credentials', [ kpxc.url, kpxc.submitUrl, force ]),
await sendMessage('retrieve_credentials', [ kpxc.url, kpxc.submitUrl, notFromCache ]),
);
}
};
Expand Down Expand Up @@ -963,7 +963,7 @@ browser.runtime.onMessage.addListener(async function(req, sender) {
} else if (req.action === 'save_credentials') {
kpxc.rememberCredentialsFromContextMenu();
} else if (req.action === 'retrive_credentials_forced') {
await kpxc.retrieveCredentials(true);
await kpxc.retrieveCredentials(true, true);
} else if (req.action === 'show_password_generator') {
kpxcPasswordGenerator.showPasswordGenerator();
} else if (req.action === 'request_autotype') {
Expand Down