fix(common): explicit error in contractToInterface - #3660
Open
dk1a wants to merge 1 commit into
Open
Conversation
|
This was referenced Apr 10, 2025
This was referenced Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently this is essentially an uncaught bug that causes
uint256[1 + 2 + 3]to becomeuint256[], which leads to incorrect system interfaces and librariesVery minor issue, I imagine people rarely if ever use expressions in static arrays, but an explicit error is better than a weird bug I guess
To actually fix this error and support complex expressions requires
unparseof some sort, which solidity-parser doesn't havenomic's slang does have
unparse, and is generally much better (and recently 1.0, which is why I didn't use it forcontractToInterfaceinitially)btw if you want I can migrate
contractToInterfaceto slang when I have time, shouldn't be hard