Skip to content

fix(world): fix static array arguments in system libraries - #3661

Merged
vdrg merged 3 commits into
latticexyz:mainfrom
dk1a:dk1a/fix-static-array-function-interface-name
Apr 17, 2025
Merged

fix(world): fix static array arguments in system libraries#3661
vdrg merged 3 commits into
latticexyz:mainfrom
dk1a:dk1a/fix-static-array-function-interface-name

Conversation

@dk1a

@dk1a dk1a commented Apr 10, 2025

Copy link
Copy Markdown
Contributor

Currently static arrays break system libs, I really like them otherwise

The TODO is related to #3660 (which is a separate PR because it affects more than system libs)

I use stringToHex to account for future possibilities like uint[1 + 2 + THREE] - escaping all those operands and whitespaces is troublesome otherwise

@dk1a
dk1a requested a review from alvrs as a code owner April 10, 2025 19:11
@changeset-bot

changeset-bot Bot commented Apr 10, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 5b32e17

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@latticexyz/world Patch
@latticexyz/cli Patch
@latticexyz/dev-tools Patch
@latticexyz/entrykit Patch
@latticexyz/explorer Patch
@latticexyz/store-sync Patch
@latticexyz/world-consumer Patch
@latticexyz/world-module-callwithsignature Patch
@latticexyz/world-module-erc20 Patch
@latticexyz/world-module-metadata Patch
@latticexyz/world-modules Patch
@latticexyz/store-indexer Patch
@latticexyz/abi-ts Patch
@latticexyz/block-logs-stream Patch
@latticexyz/common Patch
@latticexyz/config Patch
create-mud Patch
@latticexyz/faucet Patch
@latticexyz/gas-report Patch
@latticexyz/paymaster Patch
@latticexyz/protocol-parser Patch
@latticexyz/react Patch
@latticexyz/recs Patch
@latticexyz/schema-type Patch
solhint-config-mud Patch
solhint-plugin-mud Patch
@latticexyz/stash Patch
@latticexyz/store Patch
@latticexyz/utils Patch
vite-plugin-mud Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vdrg
vdrg previously approved these changes Apr 11, 2025

@vdrg vdrg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! ty

@vdrg

vdrg commented Apr 11, 2025

Copy link
Copy Markdown
Contributor

@alvrs I think it still requires a review from you as I'm not a code owner

@vdrg
vdrg merged commit f6d87ed into latticexyz:main Apr 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants