[OU-ADD] l10n_sa_edi: rename partner identification fields + preserve l10n_sa_serial_number#33
Draft
dnplkndll wants to merge 1 commit into
Draft
[OU-ADD] l10n_sa_edi: rename partner identification fields + preserve l10n_sa_serial_number#33dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
dnplkndll
added a commit
that referenced
this pull request
May 26, 2026
Track A batch of 5 l10n_* modules complete: - l10n_in_edi, l10n_ph (annotation-only) - PRs #30, #31 - l10n_tr_nilvera (selection -> boolean) - PR #32 - l10n_sa_edi (rename_fields + preserve) - PR #33 - l10n_it_edi (rename_xmlids for ndd consolidation) - PR #34 Deferred: - l10n_in_ewaybill (model move + 30+ xmlid moves, needs apriori coordination) - l10n_it sibling fix to PR #34 (l10n_it_edi_withholding -> l10n_it rename + broader tax-report refactor)
dnplkndll
changed the title
… l10n_sa_serial_number
rename_fields renames the two res.partner ZATCA fields from
l10n_sa_additional_identification_{number,scheme} to
l10n_sa_edi_additional_identification_{number,scheme} (same types,
same selection_keys; only the module prefix changes).
rename_columns preserves account_journal.l10n_sa_serial_number (DEL in
19.0) as openupgrade_legacy_19_0_* so the operator-configured ZATCA
serial survives for database_cleanup.
dnplkndll
force-pushed
the
19.0-mig-l10n_sa_edi-pre-migration
branch
from
ff4bf42 to
7d90d69
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes:
Two res.partner fields rename their prefix from
l10n_sa_tol10n_sa_edi_in 19.0 (additional_identification_number+additional_identification_scheme). The 18.0 and 19.0 signatures match exactly (same type, same selection_keys), sorename_fieldspreserves the values cleanly.account.journal.l10n_sa_serial_number(char) is DEL in 19.0. The field held the journal's ZATCA serial — operator-configured — worth preserving viarename_columnstoopenupgrade_legacy_19_0_l10n_sa_serial_numbersodatabase_cleanupcan prompt the admin later (standard OpenUpgrade preservation pattern).Draft fork PR — for review before upstreaming to OCA/OpenUpgrade.