Skip to content

[OU-ADD] l10n_sa_edi: rename partner identification fields + preserve l10n_sa_serial_number #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dnplkndll wants to merge 1 commit into
base: 19.0
Choose a base branch
from
Draft

[OU-ADD] l10n_sa_edi: rename partner identification fields + preserve l10n_sa_serial_number #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docsource/modules180-190.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ Module coverage 18.0 -> 19.0
+---------------------------------------------------+----------------------+-------------------------------------------------+
| l10n_sa | | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| l10n_sa_edi | | |
| l10n_sa_edi |Done | |
+---------------------------------------------------+----------------------+-------------------------------------------------+
| l10n_sa_edi_pos | |No DB layout changes. |
+---------------------------------------------------+----------------------+-------------------------------------------------+
Expand Down
41 changes: 41 additions & 0 deletions openupgrade_scripts/scripts/l10n_sa_edi/19.0.0.3/pre-migration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
from openupgradelib import openupgrade

# Two intersecting changes per upgrade_analysis.txt:
#
# 1. Two res.partner fields rename their prefix from `l10n_sa_` to
# `l10n_sa_edi_` (number + scheme). The 18.0 field signatures match
# the 19.0 field signatures exactly (same type, same selection_keys),
# so a direct rename_fields preserves the data without conversion.
#
# 2. account.journal.l10n_sa_serial_number is DEL in 19.0. The field
# held the journal's ZATCA serial — operator-configured, worth
# preserving as `openupgrade_legacy_19_0_l10n_sa_serial_number` so
# `database_cleanup` can prompt the admin later (standard
# OpenUpgrade preservation pattern).

_renamed_fields = [
(
"res.partner",
"res_partner",
"l10n_sa_additional_identification_number",
"l10n_sa_edi_additional_identification_number",
),
(
"res.partner",
"res_partner",
"l10n_sa_additional_identification_scheme",
"l10n_sa_edi_additional_identification_scheme",
),
]

_renamed_columns = {
"account_journal": [
("l10n_sa_serial_number", None),
],
}


@openupgrade.migrate()
def migrate(env, version):
openupgrade.rename_fields(env, _renamed_fields)
openupgrade.rename_columns(env.cr, _renamed_columns)
43 changes: 43 additions & 0 deletions openupgrade_scripts/scripts/l10n_sa_edi/19.0.0.3/upgrade_analysis_work.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
---Models in module 'l10n_sa_edi'---
---Fields in module 'l10n_sa_edi'---
l10n_sa_edi / account.journal / l10n_sa_serial_number (char) : DEL

# DONE: preserved in pre-migration as openupgrade_legacy_19_0_l10n_sa_serial_number so database_cleanup can prompt the operator (the field carried a non-trivial customer-configured value — the journal's ZATCA serial).

l10n_sa_edi / account.move / l10n_sa_edi_chain_head_id (many2one): NEW relation: account.move

# NOTHING TO DO: self-referential FK on account.move; Odoo's update_db creates the integer column with NULL on existing rows.

l10n_sa_edi / res.company / l10n_sa_edi_is_production (boolean): NEW

# NOTHING TO DO: optional boolean on res.company; Odoo's update_db adds the column with NULL on existing rows.

l10n_sa_edi / res.partner / l10n_sa_additional_identification_number (char): DEL
l10n_sa_edi / res.partner / l10n_sa_additional_identification_scheme (selection): DEL selection_keys: ['700', 'CRN', 'GCC', 'IQA', 'MLS', 'MOM', 'NAT', 'OTH', 'PAS', 'SAG', 'TIN']
l10n_sa_edi / res.partner / l10n_sa_edi_additional_identification_number (char): NEW
l10n_sa_edi / res.partner / l10n_sa_edi_additional_identification_scheme (selection): NEW selection_keys: ['700', 'CRN', 'GCC', 'IQA', 'MLS', 'MOM', 'NAT', 'OTH', 'PAS', 'SAG', 'TIN'], hasdefault: default

# DONE: rename_fields in pre-migration. Both fields keep the same type
# and selection_keys; only the prefix changes from `l10n_sa_` to
# `l10n_sa_edi_` to match the (now sole) owning module. Without this,
# the 18.0 values (partner identification scheme + number) would be
# dropped by update_db.

---XML records in module 'l10n_sa_edi'---
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_bold
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_boxed
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_bubble
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_folder
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_standard
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_striped
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_external_layout_wave
NEW ir.ui.view: l10n_sa_edi.l10n_sa_edi_report_invoice_document
NEW ir.ui.view: l10n_sa_edi.view_account_form_inherit
DEL ir.ui.view: l10n_sa_edi.arabic_english_invoice
DEL ir.ui.view: l10n_sa_edi.ubl_21_AddressType_zatca
DEL ir.ui.view: l10n_sa_edi.ubl_21_CreditNoteLineType_zatca
DEL ir.ui.view: l10n_sa_edi.ubl_21_CreditNoteType_zatca
DEL ir.ui.view: l10n_sa_edi.ubl_21_DebitNoteLineType_zatca
DEL ir.ui.view: l10n_sa_edi.ubl_21_DebitNoteType_zatca

# NOTHING TO DO: 9 NEW + 6 DEL view records replace the 18.0 UBL 2.1 template tree with a new layered-template structure. Standard module-upgrade flow handles both directions.
Loading