Skip to content

GPU: Allow multisample textures to be read #15838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
thatcosmonaut wants to merge 2 commits into
base: main
Choose a base branch
from
+5 −5
Draft

GPU: Allow multisample textures to be read #15838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc9f58
GPU: Allow multisample textures to be read
thatcosmonaut Jun 16, 2026
8795bd9
Add D3D12 Texture2DMS SRV
thatcosmonaut Jul 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/gpu/SDL_gpu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1287,11 +1287,8 @@ SDL_GPUTexture *SDL_CreateGPUTexture(
failed = true;
}
if (createinfo->sample_count > SDL_GPU_SAMPLECOUNT_1 &&
(createinfo->usage & (SDL_GPU_TEXTUREUSAGE_SAMPLER |
SDL_GPU_TEXTUREUSAGE_GRAPHICS_STORAGE_READ |
SDL_GPU_TEXTUREUSAGE_COMPUTE_STORAGE_READ |
SDL_GPU_TEXTUREUSAGE_COMPUTE_STORAGE_WRITE))) {
SDL_assert_release(!"For multisample textures: usage cannot contain SAMPLER or STORAGE flags");
(createinfo->usage & SDL_GPU_TEXTUREUSAGE_COMPUTE_STORAGE_WRITE)) {
SDL_assert_release(!"For multisample textures: usage cannot contain COMPUTE_STORAGE_WRITE flag");
failed = true;
}
if (IsDepthFormat(createinfo->format) && (createinfo->usage & ~(SDL_GPU_TEXTUREUSAGE_DEPTH_STENCIL_TARGET | SDL_GPU_TEXTUREUSAGE_SAMPLER))) {
Expand Down
3 changes: 3 additions & 0 deletions src/gpu/d3d12/SDL_gpu_d3d12.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3585,6 +3585,9 @@ static D3D12Texture *D3D12_INTERNAL_CreateTexture(
srvDesc.Texture3D.MipLevels = createinfo->num_levels;
srvDesc.Texture3D.MostDetailedMip = 0;
srvDesc.Texture3D.ResourceMinLODClamp = 0; // default behavior
} else if (createinfo->sample_count > SDL_GPU_SAMPLECOUNT_1) {
srvDesc.ViewDimension = D3D12_SRV_DIMENSION_TEXTURE2DMS;
srvDesc.Texture2DMS.UnusedField_NothingToDefine = 0;
} else {
srvDesc.ViewDimension = D3D12_SRV_DIMENSION_TEXTURE2D;
srvDesc.Texture2D.MipLevels = createinfo->num_levels;
Expand Down
Loading