Updated Identity Crisis patching recommendation#3215
Conversation
| inc: | ||
| - name: 'Identity Crisis.esp' | ||
| display: 'Identity Crisis' |
There was a problem hiding this comment.
The message is sufficient, & the incompatibility is inaccurate if they're using an older version of Identity Crisis:
| inc: | |
| - name: 'Identity Crisis.esp' | |
| display: 'Identity Crisis' |
There was a problem hiding this comment.
Sorry, been away traveling since you reviewed. If that's the case, would it be better to remove all compatibility notes for Identity Crisis? I would agree with that statement, especially due to the author's tendency to use very generic naming for their patches. Let me know if this is not preferable.
| msg: | ||
| - <<: *patchProvided | ||
| subs: [ 'Beyond Skyrim - Bruma SE' ] | ||
| condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp")' | ||
| condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp") and version("Identity Crisis.esp", <, "1.5")' |
There was a problem hiding this comment.
The version function depends on the version read from the plugin's description. The plugin doesn't have any such version in its description, so this won't work. Better to just remove the message as neither v1.4 nor the patch are readily available for download anyway.
There was a problem hiding this comment.
Thank you for explaining the usage. I'll be sure to use that correctly in the future.
| subs: [ 'Beyond Skyrim - Bruma SE' ] | ||
| condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp")' | ||
| condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp") and version("Identity Crisis.esp", <, "1.5")' | ||
|
|
There was a problem hiding this comment.
No newlines between plugins from the same page:
There was a problem hiding this comment.
Noted and no longer an issue.
| msg: | ||
| - <<: *patchOutdated | ||
| condition: 'active("BS Bruma Patch.esp") and version("Identity Crisis.esp", >=, "1.5")' | ||
|
|
There was a problem hiding this comment.
Excess newline/whitespace:
| display: 'Identity Crisis' | ||
| msg: | ||
| - <<: *patchOutdated | ||
| condition: 'active("BS Bruma Patch.esp") and version("Identity Crisis.esp", >=, "1.5")' |
There was a problem hiding this comment.
Since version doesn't work here as previously stated, you could either use checksum or make it unconditional. Checksum would be fine if the mod is unlikely to receive another update any time soon, but making it unconditional would be more reliable, & LOOT supports hiding individual messages. Also, alreadyInOrFixedByX would be clearer here, patchOutdated doesn't communicate that the patch is no longer necessary. Here's an example:
- <<: *alreadyInOrFixedByX
type: say
subs: [ 'Identity Crisis v1.5' ]There was a problem hiding this comment.
Sorry, I meant to comment this with my previous batch of comments, but I guess I forgot to actually post it. Either this or completely removing the entry are fine.
2 participants
As of Identity Crisis 1.4, a patch for Beyond Skyrim Bruma is no longer necessary nor provided. The author has resolved the conflicts. See pinned post here for details.