Skip to content

Updated Identity Crisis patching recommendation #3215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlyssaWatson wants to merge 3 commits into
base: v0.29
Choose a base branch
from
Open

Updated Identity Crisis patching recommendation #3215

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b635075
Versioned Patch and added outdated patch for outdated updated plugin
AlyssaWatson Jun 3, 2026
2adecd3
Updates after review
AlyssaWatson Jun 20, 2026
45bd6e8
Updates after review
AlyssaWatson Jun 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion masterlist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21054,7 +21054,17 @@ plugins:
msg:
- <<: *patchProvided
subs: [ 'Beyond Skyrim - Bruma SE' ]
condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp")'
condition: 'active("BSHeartland.esm") and not active("BS Bruma Patch.esp") and version("Identity Crisis.esp", <, "1.5")'

@sibir-ine sibir-ine Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version function depends on the version read from the plugin's description. The plugin doesn't have any such version in its description, so this won't work. Better to just remove the message as neither v1.4 nor the patch are readily available for download anyway.

@AlyssaWatson AlyssaWatson Jun 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for explaining the usage. I'll be sure to use that correctly in the future.


@sibir-ine sibir-ine Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No newlines between plugins from the same page:

Suggested change

@AlyssaWatson AlyssaWatson Jun 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted and no longer an issue.

- name: 'BS Bruma Patch.esp'
url: [ 'https://www.nexusmods.com/skyrimspecialedition/mods/39634/' ]
inc:
- name: 'Identity Crisis.esp'
display: 'Identity Crisis'

@sibir-ine sibir-ine Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The message is sufficient, & the incompatibility is inaccurate if they're using an older version of Identity Crisis:

Suggested change
inc:
- name: 'Identity Crisis.esp'
display: 'Identity Crisis'

@AlyssaWatson AlyssaWatson Jun 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, been away traveling since you reviewed. If that's the case, would it be better to remove all compatibility notes for Identity Crisis? I would agree with that statement, especially due to the author's tendency to use very generic naming for their patches. Let me know if this is not preferable.

msg:
- <<: *patchOutdated
condition: 'active("BS Bruma Patch.esp") and version("Identity Crisis.esp", >=, "1.5")'

@sibir-ine sibir-ine Jun 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since version doesn't work here as previously stated, you could either use checksum or make it unconditional. Checksum would be fine if the mod is unlikely to receive another update any time soon, but making it unconditional would be more reliable, & LOOT supports hiding individual messages. Also, alreadyInOrFixedByX would be clearer here, patchOutdated doesn't communicate that the patch is no longer necessary. Here's an example:

      - <<: *alreadyInOrFixedByX
        type: say
        subs: [ 'Identity Crisis v1.5' ]

@sibir-ine sibir-ine Jun 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant to comment this with my previous batch of comments, but I guess I forgot to actually post it. Either this or completely removing the entry are fine.


@sibir-ine sibir-ine Jun 10, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excess newline/whitespace:

Suggested change

@AlyssaWatson AlyssaWatson Jun 20, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted and fixed.


- name: 'Maslea.esm'
url:
Expand Down