ci(benchmark/react): force perf_controller_actor_ to use ui task runner in frozen mode

[hzy]

To compare: lynx-family/lynx@develop...hzy:lynx:p/hzy/benchx_cli

Summary by CodeRabbit

• Chores
  • Updated the build process to pull a newer upstream change, ensuring compatibility with recent updates.
  • Improves build stability and reproducibility across environments.
  • No changes to functionality or user interface.

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).
• Changeset added, and when a BREAKING CHANGE occurs, it needs to be clearly marked (or not required).

[changeset-bot]

⚠️ No Changeset found

Latest commit: 254d397

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[coderabbitai]

📝 Walkthrough

Walkthrough

Updated the PICK_COMMIT constant in packages/lynx/benchx_cli/scripts/build.mjs to a new hash, altering which upstream commit is cherry-picked during the build. No other logic or exports changed.

Changes

Cohort / File(s)	Summary of changes
Benchx CLI build script packages/lynx/benchx_cli/scripts/build.mjs	Updated PICK_COMMIT from 78493ae8581046275f6333ce16004666560ce058 to ff0c7dbe93ddf526c3a2b814215797ceeb3bb085; no other modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• ci(benchmark/react): enable "LYNX_ENABLE_FROZEN_MODE=true" #1623 — Also updates PICK_COMMIT in the same build script to a different cherry-pick target.
• ci(benchmark/react): ignore some benchmarks #1625 — Similar change adjusting the PICK_COMMIT hash in build.mjs.
• ci(benchmark/react): enable list in benchmark #1635 — Modifies the same PICK_COMMIT constant to point to another commit.

Suggested reviewers

• colinaaa
• upupming

Poem

Hop hop, I flip a hash with glee,
A cherry-pick target for build.s_m_j_s, you see!
From one long nibble to another byte,
The branch now points just right.
Carrots aligned, commits in sight—
Deploy tonight! 🥕✨

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

• Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

• Visit our Status Page to check the current availability of CodeRabbit.
• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

• MCP integration is disabled by default for public repositories
• Jira integration is disabled by default for public repositories
• Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 9e2c497 and 254d397.

📒 Files selected for processing (1)

• packages/lynx/benchx_cli/scripts/build.mjs (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-07-22T09:26:16.722Z

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:26:16.722Z
Learning: In the lynx-family/lynx-stack repository, CI checks require changesets when files matching the pattern "src/**" are modified (as configured in .changeset/config.json). For internal changes that don't need meaningful changesets, an empty changeset file is used to satisfy the CI requirement while not generating any release notes.

Applied to files:

• packages/lynx/benchx_cli/scripts/build.mjs

📚 Learning: 2025-07-22T09:23:07.797Z

Learnt from: colinaaa
PR: lynx-family/lynx-stack#1330
File: .changeset/olive-animals-attend.md:1-3
Timestamp: 2025-07-22T09:23:07.797Z
Learning: In the lynx-family/lynx-stack repository, changesets are only required for meaningful changes to end-users such as bugfixes and features. Internal/development changes like chores, refactoring, or removing debug info do not need changeset entries.

Applied to files:

• packages/lynx/benchx_cli/scripts/build.mjs

🔇 Additional comments (2)

packages/lynx/benchx_cli/scripts/build.mjs (2)

115-115: Confirm frozen mode configuration aligns with PR objectives.

The build arguments include enable_frozen_mode=true which aligns with the PR title mentioning "frozen mode". This suggests the commit being cherry-picked contains changes that affect behavior specifically when frozen mode is enabled.

---

99-102: Verify cherry-pick will apply cleanly before running the script.
Simulate the cherry-pick in an isolated worktree or as a patch to avoid conflicts in your main workspace:

• Worktree approach:

  git fetch origin
  git worktree add /tmp/tw TARGET-branch
  cd /tmp/tw
  git cherry-pick <PICK_COMMIT> --no-commit    # exit code 0 = no conflicts
  cd -; git worktree remove /tmp/tw --force; git worktree prune

• Patch check approach:

  git format-patch -1 <PICK_COMMIT> --stdout \
    | git apply --3way --check -             # exit code 0 = clean apply

Ensure one of these exits with status 0 before merging the updated commit into your release.

[coderabbitai]

💡 Verification agent

🧩 Analysis chain

Update commit hash without documentation - verify the change is intentional.

The PICK_COMMIT constant has been updated from 78493ae8581046275f6333ce16004666560ce058 to ff0c7dbe93ddf526c3a2b814215797ceeb3bb085. This change aligns with the PR title mentioning forcing perf_controller_actor_ to use UI task runner in frozen mode, but there's no documentation about what this specific commit contains.

Please verify that this commit hash update is correct by running the following script to check what changes are included in the new commit:

---

🏁 Script executed:

#!/bin/bash
# Description: Verify the commit hash and examine the changes it introduces
# Expected: The commit should contain changes related to perf_controller_actor_ and UI task runner

# Check if the new commit exists in the hzy/lynx repository
curl -s "https://api.github.com/repos/hzy/lynx/commits/ff0c7dbe93ddf526c3a2b814215797ceeb3bb085" | jq -r '.commit.message, .commit.author.date'

# Also check what the old commit was about for comparison
curl -s "https://api.github.com/repos/hzy/lynx/commits/78493ae8581046275f6333ce16004666560ce058" | jq -r '.commit.message, .commit.author.date'

Length of output: 1209

---

Correct PICK_COMMIT to the intended perf_controller_actor_ change.
Both the old (78493ae8581046275f6333ce16004666560ce058) and new (ff0c7dbe93ddf526c3a2b814215797ceeb3bb085) hashes reference the benchx_cli introduction commit from 2025-08-22, not the perf_controller_actor_ UI task-runner update mentioned in the PR. Update the hash at packages/lynx/benchx_cli/scripts/build.mjs:33 to the correct commit or document why this benchx_cli commit is being picked.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

[relativeci]

React Example

#4850 Bundle Size — 237.5KiB (0%).

254d397(current) vs 9e2c497 main#4838(baseline)

Bundle metrics  no changes

	Current #4850	Baseline #4838
Initial JS	0B	0B
Initial CSS	0B	0B
Cache Invalidation	0%	0%
Chunks	0	0
Assets	4	4
Modules	160	160
Duplicate Modules	65	65
Duplicate Code	45.83%	45.83%
Packages	2	2
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4850	Baseline #4838
IMG	145.76KiB	145.76KiB
Other	91.74KiB	91.74KiB

Bundle analysis report Branch hzy:p/hzy/bench_7 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[relativeci]

Web Explorer

#4841 Bundle Size — 367.43KiB (0%).

254d397(current) vs 9e2c497 main#4829(baseline)

Bundle metrics   1 change

	Current #4841	Baseline #4829
Initial JS	144.23KiB	144.23KiB
Initial CSS	31.84KiB	31.84KiB
Cache Invalidation	0%	0%
Chunks	8	8
Assets	8	8
Modules	219	219
Duplicate Modules	16	16
Duplicate Code	3.33%(+0.3%)	3.32%
Packages	4	4
Duplicate Packages	0	0

Bundle size by type  no changes

	Current #4841	Baseline #4829
JS	235.43KiB	235.43KiB
Other	100.16KiB	100.16KiB
CSS	31.84KiB	31.84KiB

Bundle analysis report Branch hzy:p/hzy/bench_7 Project dashboard

---

^{Generated by RelativeCI Documentation Report issue}

[Copilot]

Pull Request Overview

This PR updates the commit hash used by the benchmark CLI build script to ensure the perf_controller_actor_ uses the UI task runner in frozen mode for more accurate benchmarking results.

• Updates the PICK_COMMIT constant to reference a newer commit that contains the necessary performance controller changes

[codspeed-hq]

CodSpeed Performance Report

Merging #1657 will degrade performances by 12.77%

_{Comparing hzy:p/hzy/bench_7 (254d397) with main (9e2c497)}

Summary

❌ 2 regressions
✅ 40 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	002-hello-reactLynx-destroyBackground	601.6 µs	689.7 µs	-12.77%
❌	basic-performance-div-100	6 ms	6.7 ms	-11.49%

[upupming]

I am wondering if we can use branch name instead of commit id. If we use branch name, we always use the first commit of the branch as PICK_COMMIT, then we will never need update this file on any updates.