Skip to content

ci(benchmark/react): force perf_controller_actor_ to use ui task runner in frozen mode #1657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinaaa merged 1 commit into from
Sep 5, 2025
Merged

ci(benchmark/react): force perf_controller_actor_ to use ui task runner in frozen mode #1657

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/lynx/benchx_cli/scripts/build.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ console.log('noop')
}

const COMMIT = 'd6dd806293012c62e5104ad7ed2bed5c66f4f833';
const PICK_COMMIT = '78493ae8581046275f6333ce16004666560ce058';
const PICK_COMMIT = 'ff0c7dbe93ddf526c3a2b814215797ceeb3bb085';
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Update commit hash without documentation - verify the change is intentional.

The PICK_COMMIT constant has been updated from 78493ae8581046275f6333ce16004666560ce058 to ff0c7dbe93ddf526c3a2b814215797ceeb3bb085. This change aligns with the PR title mentioning forcing perf_controller_actor_ to use UI task runner in frozen mode, but there's no documentation about what this specific commit contains.

Please verify that this commit hash update is correct by running the following script to check what changes are included in the new commit:

🏁 Script executed:

#!/bin/bash
# Description: Verify the commit hash and examine the changes it introduces
# Expected: The commit should contain changes related to perf_controller_actor_ and UI task runner

# Check if the new commit exists in the hzy/lynx repository
curl -s "https://api.github.com/repos/hzy/lynx/commits/ff0c7dbe93ddf526c3a2b814215797ceeb3bb085" | jq -r '.commit.message, .commit.author.date'

# Also check what the old commit was about for comparison
curl -s "https://api.github.com/repos/hzy/lynx/commits/78493ae8581046275f6333ce16004666560ce058" | jq -r '.commit.message, .commit.author.date'

Length of output: 1209

Correct PICK_COMMIT to the intended perf_controller_actor_ change.
Both the old (78493ae8581046275f6333ce16004666560ce058) and new (ff0c7dbe93ddf526c3a2b814215797ceeb3bb085) hashes reference the benchx_cli introduction commit from 2025-08-22, not the perf_controller_actor_ UI task-runner update mentioned in the PR. Update the hash at packages/lynx/benchx_cli/scripts/build.mjs:33 to the correct commit or document why this benchx_cli commit is being picked.

Copy link
Copy Markdown
Collaborator

@upupming upupming Sep 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering if we can use branch name instead of commit id. If we use branch name, we always use the first commit of the branch as PICK_COMMIT, then we will never need update this file on any updates.


function checkCwd() {
try {
Expand Down
Loading