refactor(react-runtime): dedupe hook callbacks by colinaaa · Pull Request #2350 · lynx-family/lynx-stack

colinaaa · 2026-03-18T14:04:01Z

This slices the hook callback dedup optimization out of the bundle-size work.

Changes:

Share the render hook wrapper in packages/react/runtime/src/lifecycle/isRendering.ts
Share the timing hook wrapper in packages/react/runtime/src/lynx/performance.ts
Remove the now-unused preact VNode type import

Validation:

git diff --check

Commit: e9c7554
issue: #17

Summary by CodeRabbit

Refactor
- Internal code consolidation and cleanup for improved maintainability.

changeset-bot · 2026-03-18T14:04:07Z

⚠️ No Changeset found

Latest commit: e320ccb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-03-18T14:04:20Z

📝 Walkthrough

Walkthrough

The PR refactors duplicate hook callback logic in React runtime lifecycle handling by consolidating RENDER_COMPONENT and ROOT hook callbacks into shared utility functions, eliminating code duplication while preserving existing behavior and call order.

Changes

Cohort / File(s)	Summary
Lifecycle Hook Consolidation `packages/react/runtime/src/lifecycle/isRendering.ts`, `packages/react/runtime/src/lynx/performance.ts`	Refactors duplicate inline hook callbacks for RENDER_COMPONENT and ROOT hooks into shared handler functions. Replaces per-hook type annotations with generic rest parameters, guards handler invocations, and removes unused imports, eliminating code duplication while preserving execution order and behavior.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

chore: upgrade preact #1389 — Refactors lifecycle hook callbacks in packages/react/runtime using the same pattern of consolidating inline handlers into shared utilities.
feat(react/runtime): add rendering state tracking #1445 — Modifies isRendering hook logic with similar refactoring of callback consolidation in lifecycle handling.

Suggested labels

framework:React

Suggested reviewers

Yradex
hzy

Poem

🐰 Hooks once doubled, now consolidated,
Shared handlers keep the flow delegated,
Code deduped, but logic stays the same,
Cleaner branches win the refactor game! ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: deduplication of hook callbacks across two files to reduce code duplication.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-18T14:10:30Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9c7554eda

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codspeed-hq · 2026-03-18T14:20:35Z

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 21 skipped benchmarks¹

_{Comparing colinaaa:codex/hook-callback-dedup (e320ccb) with main (95fff27)²}

21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (9193711) during the generation of this report, so 95fff27 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

relativeci · 2026-03-18T14:23:22Z

Web Explorer

#8503 Bundle Size — 728.6KiB (0%).

e320ccb(current) vs 9193711 main#8502(baseline)

Bundle metrics

1 change

	Current #8503	Baseline #8502
Initial JS	`43.3KiB`	`43.3KiB`
Initial CSS	`2.16KiB`	`2.16KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`10`	`10`
Modules	`148`(`-0.67%`)	`149`
Duplicate Modules	`11`	`11`
Duplicate Code	`34.69%`	`34.69%`
Packages	`3`	`3`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8503	Baseline #8502
Other	`384.4KiB`	`384.4KiB`
JS	`342.04KiB`	`342.04KiB`
CSS	`2.16KiB`	`2.16KiB`

Bundle analysis report Branch colinaaa:codex/hook-callback-ded... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-03-28T04:16:05Z

React MTF Example

#59 Bundle Size — 207.39KiB (-0.04%).

e320ccb(current) vs 9193711 main#58(baseline)

Bundle metrics

1 change

	Current #59	Baseline #58
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`46.39%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`174`	`174`
Duplicate Modules	`68`	`68`
Duplicate Code	`46.09%`	`46.09%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #59	Baseline #58
IMG	`111.23KiB`	`111.23KiB`
Other	`96.16KiB` (`-0.08%`)	`96.24KiB`

Bundle analysis report Branch colinaaa:codex/hook-callback-ded... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-03-28T04:16:08Z

React Example

#6925 Bundle Size — 237.82KiB (-0.03%).

e320ccb(current) vs 9193711 main#6924(baseline)

Bundle metrics

1 change

	Current #6925	Baseline #6924
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`38.73%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`180`	`180`
Duplicate Modules	`71`	`71`
Duplicate Code	`46.4%`	`46.4%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #6925	Baseline #6924
IMG	`145.76KiB`	`145.76KiB`
Other	`92.06KiB` (`-0.08%`)	`92.13KiB`

Bundle analysis report Branch colinaaa:codex/hook-callback-ded... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Yradex

看过了。这个改动是纯粹的 hook callback 去重：调用顺序没变，副作用也还是先 old hook 再 set/helper，没有引入新的语义分叉。CI 也全绿。

refactor(react-runtime): dedupe hook callbacks

e9c7554

colinaaa requested review from HuJean, Yradex and hzy as code owners March 18, 2026 14:04

coderabbitai Bot added the framework:React label Mar 18, 2026

chatgpt-codex-connector Bot reviewed Mar 18, 2026

View reviewed changes

Comment thread packages/react/runtime/src/lynx/performance.ts

Merge branch 'main' into codex/hook-callback-dedup

e320ccb

Yradex approved these changes Mar 30, 2026

View reviewed changes

Yradex merged commit 495ad36 into lynx-family:main Mar 30, 2026
50 checks passed

Conversation

colinaaa commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

changeset-bot Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

codecov Bot commented Mar 18, 2026

Codecov Report

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

codspeed-hq Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

relativeci Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#8503 Bundle Size — 728.6KiB (0%).

Uh oh!

relativeci Bot commented Mar 28, 2026

React MTF Example

#59 Bundle Size — 207.39KiB (-0.04%).

Uh oh!

relativeci Bot commented Mar 28, 2026

React Example

#6925 Bundle Size — 237.82KiB (-0.03%).

Uh oh!

Yradex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colinaaa commented Mar 18, 2026 •

edited

Loading

changeset-bot Bot commented Mar 18, 2026 •

edited

Loading

coderabbitai Bot commented Mar 18, 2026 •

edited

Loading

codspeed-hq Bot commented Mar 18, 2026 •

edited

Loading

relativeci Bot commented Mar 18, 2026 •

edited

Loading