Skip to content

refactor(react-runtime): dedupe hook callbacks #2350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yradex merged 2 commits into from
Mar 30, 2026
Merged

refactor(react-runtime): dedupe hook callbacks #2350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9c7554
refactor(react-runtime): dedupe hook callbacks
colinaaa Mar 18, 2026
e320ccb
Merge branch 'main' into codex/hook-callback-dedup
colinaaa Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions packages/react/runtime/src/lifecycle/isRendering.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,11 @@ const setIsRendering = () => {
});
};

hook(options, RENDER_COMPONENT, (old, ...args) => {
const onRenderHook = <T extends unknown[]>(old: ((...args: T) => void) | undefined, ...args: T) => {
/* v8 ignore next */
old?.(...args);
if (old) old(...args);
setIsRendering();
});
};

hook(options, ROOT, (old, ...args) => {
/* v8 ignore next */
old?.(...args);
setIsRendering();
});
hook(options, RENDER_COMPONENT, onRenderHook);
hook(options, ROOT, onRenderHook);
19 changes: 5 additions & 14 deletions packages/react/runtime/src/lynx/performance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
// Licensed under the Apache License Version 2.0 that can be found in the
// LICENSE file in the root directory of this source tree.
import { options } from 'preact';
import type { VNode } from 'preact';

import { __globalSnapshotPatch } from '../lifecycle/patch/snapshotPatch.js';
import { RENDER_COMPONENT, ROOT } from '../renderToOpcodes/constants.js';
Expand Down Expand Up @@ -130,23 +129,15 @@ function initTimingAPI(): void {
}
};

hook(options, RENDER_COMPONENT, (old, vnode: VNode, c) => {
const onHook = <T extends unknown[]>(old: ((...args: T) => void) | undefined, ...args: T) => {
helper();
/* v8 ignore start */
if (old) {
old(vnode, c);
}
if (old) old(...args);
Comment thread
colinaaa marked this conversation as resolved.
/* v8 ignore stop */
});
};

hook(options, ROOT, (old, vnode: VNode, parentDom) => {
helper();
/* v8 ignore start */
if (old) {
old(vnode, parentDom);
}
/* v8 ignore stop */
});
hook(options, RENDER_COMPONENT, onHook);
hook(options, ROOT, onHook);
}

/**
Expand Down
Loading