perf(react-runtime): trim snapshot and commit hot paths by colinaaa · Pull Request #2353 · lynx-family/lynx-stack

colinaaa · 2026-03-18T14:12:12Z

This extracts the misc micro-trims from bundle-size into a standalone slice.

simplify BackgroundSnapshotInstance.childNodes() by iterating directly until null
drop redundant guards in commit patch assembly now that snapshotPatch is guaranteed after the early return

Validation: git diff --check

pnpm exec biome check could not run in this worktree because biome is not installed locally.

issue: #17

Summary by CodeRabbit

Refactor
- Optimized internal conditional logic for improved code efficiency.
- Enhanced child node traversal handling for better performance.

- remove the redundant childNodes break guard in BackgroundSnapshotInstance - simplify commit patch guards now that snapshotPatch is always defined after the early return Validation: git diff --check

coderabbitai · 2026-03-18T14:12:36Z

📝 Walkthrough

Walkthrough

Two files in the snapshot and lifecycle modules are refined. The patch commit logic removes redundant null-chaining guards leveraging existing control flow. The background snapshot child node traversal is modified to eliminate early loop termination, iterating solely via sibling linkage.

Changes

Cohort / File(s)	Summary
Snapshot Lifecycle Cleanup `packages/react/runtime/src/lifecycle/patch/commit.ts`	Simplified conditional guards by removing optional-chaining syntax (`?.`) in two places: `snapshotPatch?.length` becomes `snapshotPatch.length`, and `snapshotPatch && delayedRunOnMainThreadData.length` becomes `delayedRunOnMainThreadData.length`, relying on existing early-return control flow.
Node Traversal Logic `packages/react/runtime/src/snapshot/backgroundSnapshot.ts`	Removed early-termination condition in `BackgroundSnapshotInstance.childNodes` loop; node iteration now continues via sibling chain until completion rather than stopping at recorded `__lastChild`.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

refactor(react/runtime): improve cleanup of snapshot instances #1293: Modifies snapshot cleanup flow and affects the same files (commit.ts and backgroundSnapshot.ts), relating to BackgroundSnapshotInstance lifecycle and commit-time cleanup behavior.

Suggested reviewers

HuJean
Yradex
hzy

Poem

🐰 With guards now cleaner and loops set free,
The snapshot hops through sibling spree,
No early stops to break the chain,
Just simple truths—no null refrain,
Efficiency bounds through the tree!

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'perf(react-runtime): trim snapshot and commit hot paths' directly summarizes the main changes: performance optimizations in snapshot and commit code paths by removing redundant guards and simplifying traversal logic.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2026-03-18T14:15:55Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

codspeed-hq · 2026-03-18T14:29:18Z

Merging this PR will degrade performance by 21.09%

❌ 1 regressed benchmark
✅ 71 untouched benchmarks
⏩ 21 skipped benchmarks¹

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`002-hello-reactLynx-destroyBackground`	679.4 µs	861 µs	-21.09%

_{Comparing colinaaa:codex/runtime-micro-trims (28a3855) with main (95fff27)²}

21 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
No successful run was found on main (9193711) during the generation of this report, so 95fff27 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

relativeci · 2026-03-18T14:30:43Z

Web Explorer

#8506 Bundle Size — 728.6KiB (0%).

28a3855(current) vs 7b7a0c6 main#8505(baseline)

Bundle metrics

1 change

	Current #8506	Baseline #8505
Initial JS	`43.3KiB`	`43.3KiB`
Initial CSS	`2.16KiB`	`2.16KiB`
Cache Invalidation	`0%`	`0%`
Chunks	`8`	`8`
Assets	`10`	`10`
Modules	`148`(`-0.67%`)	`149`
Duplicate Modules	`11`	`11`
Duplicate Code	`34.69%`	`34.69%`
Packages	`3`	`3`
Duplicate Packages	`0`	`0`

Bundle size by type no changes

	Current #8506	Baseline #8505
Other	`384.4KiB`	`384.4KiB`
JS	`342.04KiB`	`342.04KiB`
CSS	`2.16KiB`	`2.16KiB`

Bundle analysis report Branch colinaaa:codex/runtime-micro-tri... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

…-trims

changeset-bot · 2026-03-28T04:01:31Z

⚠️ No Changeset found

Latest commit: 28a3855

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

relativeci · 2026-03-28T04:19:06Z

React Example

#6928 Bundle Size — 237.85KiB (-0.02%).

28a3855(current) vs 7b7a0c6 main#6927(baseline)

Bundle metrics

1 change

	Current #6928	Baseline #6927
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`38.73%`	`0%`
Chunks	`0`	`0`
Assets	`4`	`4`
Modules	`180`	`180`
Duplicate Modules	`71`	`71`
Duplicate Code	`46.4%`	`46.4%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #6928	Baseline #6927
IMG	`145.76KiB`	`145.76KiB`
Other	`92.09KiB` (`-0.05%`)	`92.13KiB`

Bundle analysis report Branch colinaaa:codex/runtime-micro-tri... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

relativeci · 2026-03-28T04:19:33Z

React MTF Example

#62 Bundle Size — 207.43KiB (-0.02%).

28a3855(current) vs 7b7a0c6 main#61(baseline)

Bundle metrics

1 change

	Current #62	Baseline #61
Initial JS	`0B`	`0B`
Initial CSS	`0B`	`0B`
Cache Invalidation	`46.39%`	`0%`
Chunks	`0`	`0`
Assets	`3`	`3`
Modules	`174`	`174`
Duplicate Modules	`68`	`68`
Duplicate Code	`46.09%`	`46.09%`
Packages	`2`	`2`
Duplicate Packages	`0`	`0`

Bundle size by type

1 change

1 improvement

	Current #62	Baseline #61
IMG	`111.23KiB`	`111.23KiB`
Other	`96.19KiB` (`-0.04%`)	`96.24KiB`

Bundle analysis report Branch colinaaa:codex/runtime-micro-tri... Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Yradex

看过了。这个 PR 基本是删冗余 guard：childNodes() 直接靠 linked-list 终止条件退出，commit.ts 里 snapshotPatch 在前置 return 之后也确实恒存在，改动和声明一致。CI 也全绿。

perf(react-runtime): trim snapshot and commit hot paths

e0fb15d

- remove the redundant childNodes break guard in BackgroundSnapshotInstance - simplify commit patch guards now that snapshotPatch is always defined after the early return Validation: git diff --check

colinaaa requested review from HuJean, Yradex and hzy as code owners March 18, 2026 14:12

coderabbitai Bot added the framework:React label Mar 18, 2026

Merge remote-tracking branch 'upstream/main' into codex/runtime-micro…

28a3855

…-trims

Yradex approved these changes Mar 30, 2026

View reviewed changes

Yradex merged commit a853b7a into lynx-family:main Mar 30, 2026
74 of 79 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(react-runtime): trim snapshot and commit hot paths#2353

perf(react-runtime): trim snapshot and commit hot paths#2353
Yradex merged 2 commits intolynx-family:mainfrom
colinaaa:codex/runtime-micro-trims

colinaaa commented Mar 18, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Mar 18, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

codspeed-hq Bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Mar 18, 2026 •

edited

Loading

Uh oh!

changeset-bot Bot commented Mar 28, 2026

Uh oh!

relativeci Bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

relativeci Bot commented Mar 28, 2026 •

edited

Loading

Uh oh!

Yradex left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

colinaaa commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

codecov Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

codspeed-hq Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 21.09%

Performance Changes

Footnotes

Uh oh!

relativeci Bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Web Explorer

#8506 Bundle Size — 728.6KiB (0%).

Uh oh!

changeset-bot Bot commented Mar 28, 2026

⚠️ No Changeset found

Uh oh!

relativeci Bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React Example

#6928 Bundle Size — 237.85KiB (-0.02%).

Uh oh!

relativeci Bot commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

React MTF Example

#62 Bundle Size — 207.43KiB (-0.02%).

Uh oh!

Yradex left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

colinaaa commented Mar 18, 2026 •

edited

Loading

coderabbitai Bot commented Mar 18, 2026 •

edited

Loading

codecov Bot commented Mar 18, 2026 •

edited

Loading

codspeed-hq Bot commented Mar 18, 2026 •

edited

Loading

relativeci Bot commented Mar 18, 2026 •

edited

Loading

relativeci Bot commented Mar 28, 2026 •

edited

Loading

relativeci Bot commented Mar 28, 2026 •

edited

Loading