Skip to content

perf(react-runtime): trim snapshot and commit hot paths #2353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yradex merged 2 commits into from
Mar 30, 2026
+2 −5
Merged

perf(react-runtime): trim snapshot and commit hot paths #2353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0fb15d
perf(react-runtime): trim snapshot and commit hot paths
colinaaa Mar 18, 2026
28a3855
Merge remote-tracking branch 'upstream/main' into codex/runtime-micro…
colinaaa Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/runtime/src/lifecycle/patch/commit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ function replaceCommitHook(): void {
id: commitTaskId,
};
// TODO: check all fields in `flushOptions` from runtime3
if (snapshotPatch?.length) {
if (snapshotPatch.length) {
patch.snapshotPatch = snapshotPatch;
}
const patchList: PatchList = {
Expand All @@ -162,7 +162,7 @@ function replaceCommitHook(): void {
if (!isEmptyObject(flushOptions)) {
patchList.flushOptions = flushOptions;
}
if (snapshotPatch && delayedRunOnMainThreadData.length) {
if (delayedRunOnMainThreadData.length) {
patchList.delayedRunOnMainThreadData = takeDelayedRunOnMainThreadData();
}
const obj = commitPatchUpdate(patchList, patchOptions);
Expand Down
3 changes: 0 additions & 3 deletions packages/react/runtime/src/snapshot/backgroundSnapshot.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,9 +282,6 @@ export class BackgroundSnapshotInstance {
let node = this.__firstChild;
while (node) {
nodes.push(node);
if (node === this.__lastChild) {
break;
}
node = node.__nextSibling;
}
return nodes;
Expand Down
Loading