Merged
Conversation
Member
Author
|
@marionettejs/marionette-core can I get some 👀 |
Member
|
LGTM 👍 Ran a sanity check against my app and in IE8. No apparent issues. |
Contributor
|
any news one this release? |
Member
|
just waiting on some responses from people :) I may just cherrypick e787839 to get the bug fix out the door and we can work on getting the rest of the fixes in |
Member
Author
|
@ping @jasonLaster @ianmstew you guys free to answer @samccone 's questions? |
Member
|
Left some comments. I say we do one deploy soonish. |
Member
|
Is this missing #2384 |
Contributor
|
seems so |
This was referenced Jun 3, 2015
Member
Author
|
@paulfalgout added #2384 |
Member
Author
|
ok ive added waiting on #2561 and will build libs again |
Member
Author
|
@samccone now that the dep bump is merged im gonna create a new 2.4.2 branch. what do we want in it? I'd say at least: @e787839 and the dep bump. Thoughts? |
Member
|
👍 |
1 similar comment
Member
|
👍 |
paulfalgout
added a commit
that referenced
this pull request
Jun 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.