[EHR] use API Error type for in-house medications and show errors on Frontend#7021
Merged
ValeriyDyachenko merged 5 commits intodevelopfrom Apr 15, 2026
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes backend error responses for the in-house medication order flow by throwing APIError-shaped errors (instead of generic Error) and updates the EHR frontend to display server-provided error messages when medication updates/deletes fail.
Changes:
- Backend: replace generic
Errorthrows withINVALID_INPUT_ERROR,MISSING_REQUEST_BODY, andFHIR_RESOURCE_NOT_FOUND_CUSTOMfor medication order validation and resource fetching. - Frontend: update medication delete/save error handling to surface API-provided error messages to users (when available).
- Introduce additional “not found” error handling in medication order resource loading.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/zambdas/src/ehr/create-update-medication-order/validateRequestParameters.ts | Uses APIError types for request validation failures. |
| packages/zambdas/src/ehr/create-update-medication-order/index.ts | Uses APIError types for invalid state transitions and missing FHIR resources. |
| packages/zambdas/src/ehr/create-update-medication-order/helpers.ts | Uses APIError types for provider/access validation and missing resources. |
| apps/ehr/src/features/visits/in-person/components/medication-administration/medication-editable-card/EditableMedicationCard.tsx | Displays API error messages in snackbars for delete/save failures. |
| apps/ehr/src/features/visits/in-person/components/medication-administration/mar/MedicationActions.tsx | Displays API error messages for MAR delete failures. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
VladMstv
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.