Skip to content

Add check_name field & GitLab severity mapping #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emanguy wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add check_name field & GitLab severity mapping #1

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ffd294e
Add "check_name" field to output
emanguy Sep 10, 2024
ae8a48d
Switch repo declaration for testing
emanguy Sep 10, 2024
15522c3
Revert "Switch repo declaration for testing"
emanguy Sep 10, 2024
5dd86df
Convert staticcheck severities to gitlab severities
emanguy Sep 10, 2024
ffe6d38
Merge branch 'main' into add-checkname-field
emanguy Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type StaticCheckEntry struct {
}

type GitlabCIEntry struct {
CheckName string `json:"check_name"`
Description string `json:"description"`
Fingerprint string `json:"fingerprint"`
Severity string `json:"severity"`
Expand All @@ -45,9 +46,10 @@ func main() {
}

var gitlabEntry GitlabCIEntry
gitlabEntry.CheckName = entry.Code
gitlabEntry.Description = entry.Message
gitlabEntry.Fingerprint = fmt.Sprintf("%s%s%d%d", entry.Code, entry.Location.File, entry.Location.Line, entry.Location.Column)
gitlabEntry.Severity = entry.Severity
gitlabEntry.Severity = staticcheckSevToGitlabSev(entry.Severity)

gitlabEntry.Location.Path = getRelativePath(entry.Location.File)
gitlabEntry.Location.Lines.Begin = entry.Location.Line
Expand All @@ -71,3 +73,18 @@ func getRelativePath(absolutePath string) string {
}
return strings.ReplaceAll(absolutePath, path+"/", "")
}

func staticcheckSevToGitlabSev(scSev string) string {
// Staticcheck severities pulled from here: https://github.com/dominikh/go-tools/blob/915b568982be0ad65a98e822471748b328240ed0/lintcmd/lint.go#L373
// Gitlab severities pulled from here: https://docs.gitlab.com/ee/ci/testing/code_quality.html#implement-a-custom-tool
switch scSev {
case "ignored":
return "info"
case "warning":
return "minor"
case "error":
return "major"
default:
return scSev
}
}