Skip to content

[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering - #10053

Open
Chethan Thopaiah (ChethanT) wants to merge 1 commit into
releases/28.4from
cleanup/Subcontracting/reenable-rules-28.4
Open

[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering#10053
Chethan Thopaiah (ChethanT) wants to merge 1 commit into
releases/28.4from
cleanup/Subcontracting/reenable-rules-28.4

Conversation

@ChethanT

@ChethanT Chethan Thopaiah (ChethanT) commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

What & why

Re-enables the AppSourceCop rules that were temporarily disabled for the Subcontracting object renumbering and removes the temporary AS0072/AS0136 pragmas added to the Subcontracting app.

This PR contains only ruleset and pragma cleanup. It does not change application behavior.

Rules re-enabled

  • AS0001
  • AS0018
  • AS0029
  • AS0088
  • AS0106

Linked work

Fixes AB#646188

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@ChethanT
Chethan Thopaiah (ChethanT) requested review from a team August 7, 2026 14:04
@ChethanT
Chethan Thopaiah (ChethanT) requested a review from a team as a code owner August 7, 2026 14:04
@github-actions github-actions Bot added AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area labels Aug 7, 2026
@github-actions github-actions Bot added this to the Version 28.4 milestone Aug 7, 2026
@alexei-dobriansky

Copy link
Copy Markdown
Contributor

Agentic PR Review - Round 1

Recommendation: Accept

What this PR does

This PR removes the temporary AppSourceCop suppression that was put in place during the Subcontracting app object renumbering. It re-enables five rules (AS0001, AS0018, AS0029, AS0088, AS0106) in the global ruleset from "None" back to "Error", and removes the file-level #pragma warning disable/restore AS0072, AS0136 pairs from all ~100 affected Subcontracting source files.

The change is correct: the ruleset entries match the rules listed in the PR description, and the pragma removal covers every file that had the suppression. No application logic is touched, so the only observable effect is that the compiler will now enforce these rules again. The PR does not change any object IDs, fields, events, or behavior.

Suggestions

None.

Risk assessment and necessity

Risk: Very low. This is a pure tooling cleanup with no runtime behavior. The only risk is that a Subcontracting file still violates one of the re-enabled rules after the renumbering — if so, CI will catch it during this PR's validation run. There are no public API, event, or table field changes.

Necessity: Required. Leaving the rules suppressed after the renumbering is complete would permanently weaken AppSourceCop coverage for the Subcontracting app. The cleanup is scoped correctly to the files and rules that were temporarily suppressed.


[AI-PR-REVIEW] version=1 promptVersion=1 system=github pr=10053 round=1 by=alexei-dobriansky at=2026-08-10T07:50:24Z lastSha=b9bb09c2b6b2789a499e99185f62d2a34c135f74 reviewKey=0e24d74187b0a6dc5de54c43b709bb26dcb2b1db8dcbd6cd36222b93262bf551 suggestions=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AL: Apps (W1) Add-on apps for W1 SCM GitHub request for SCM area

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants