[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering - #10053
[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering#10053Chethan Thopaiah (ChethanT) wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Agentic PR Review - Round 1Recommendation: AcceptWhat this PR doesThis PR removes the temporary AppSourceCop suppression that was put in place during the Subcontracting app object renumbering. It re-enables five rules (AS0001, AS0018, AS0029, AS0088, AS0106) in the global ruleset from "None" back to "Error", and removes the file-level #pragma warning disable/restore AS0072, AS0136 pairs from all ~100 affected Subcontracting source files. The change is correct: the ruleset entries match the rules listed in the PR description, and the pragma removal covers every file that had the suppression. No application logic is touched, so the only observable effect is that the compiler will now enforce these rules again. The PR does not change any object IDs, fields, events, or behavior. SuggestionsNone. Risk assessment and necessityRisk: Very low. This is a pure tooling cleanup with no runtime behavior. The only risk is that a Subcontracting file still violates one of the re-enabled rules after the renumbering — if so, CI will catch it during this PR's validation run. There are no public API, event, or table field changes. Necessity: Required. Leaving the rules suppressed after the renumbering is complete would permanently weaken AppSourceCop coverage for the Subcontracting app. The cleanup is scoped correctly to the files and rules that were temporarily suppressed.
|
What & why
Re-enables the AppSourceCop rules that were temporarily disabled for the Subcontracting object renumbering and removes the temporary
AS0072/AS0136pragmas added to the Subcontracting app.This PR contains only ruleset and pragma cleanup. It does not change application behavior.
Rules re-enabled
Linked work
Fixes AB#646188