Skip to content

[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering #10053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Chethan Thopaiah (ChethanT) wants to merge 2 commits into
base: releases/28.4
Choose a base branch
from
Open

[28.4] Re-enable AppSourceCop rules after Subcontracting renumbering #10053

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9bb09c
Re-enable AppSourceCop rules after Subcontracting renumbering
ChethanT Aug 7, 2026
9344ac2
update baseline
ChethanT Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/Packages.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"Source": "NuGet.org"
},
"AppBaselines-BCArtifacts": {
"Version": "28.3.52162.53285",
"Version": "28.3.52162.53526",
"Source": "BCArtifacts",
"_comment": "Used to fetch app baselines from BC artifacts"
}
Expand Down
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcFeatureFlagHandler.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using Microsoft.Manufacturing.Setup;

#pragma warning disable AS0072, AS0136
codeunit 20569 "Subc. Feature Flag Handler"
{
ObsoleteState = Pending;
Expand All @@ -25,5 +24,4 @@ codeunit 20569 "Subc. Feature Flag Handler"
exit(not ManufacturingSetup."Legacy Subcontracting");
end;
}
#pragma warning restore AS0072, AS0136
#endif
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcILEntries.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using Microsoft.Inventory.Ledger;

#pragma warning disable AS0072, AS0136
pageextension 20501 "Subc. ILEntries" extends "Item Ledger Entries"
{
layout
Expand Down Expand Up @@ -121,4 +120,3 @@ pageextension 20501 "Subc. ILEntries" extends "Item Ledger Entries"
SubcPurchFactboxMgmt.ShowPurchaseOrder(RecRelatedVariant);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcItemJnlPostLineExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ using Microsoft.Inventory.Posting;
using Microsoft.Manufacturing.Capacity;
using Microsoft.Manufacturing.Document;

#pragma warning disable AS0072, AS0136
codeunit 20515 "Subc. ItemJnlPostLine Ext"
{
#if not CLEAN28
Expand Down Expand Up @@ -135,4 +134,3 @@ codeunit 20515 "Subc. ItemJnlPostLine Ext"
ValueEntry."Item Charge No." := ItemJournalLine."Item Charge No.";
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcItemLedgerEntry.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace Microsoft.Manufacturing.Subcontracting;
using Microsoft.Inventory.Ledger;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
tableextension 20500 "Subc. Item Ledger Entry" extends "Item Ledger Entry"
{
AllowInCustomizations = AsReadOnly;
Expand Down Expand Up @@ -47,4 +46,3 @@ tableextension 20500 "Subc. Item Ledger Entry" extends "Item Ledger Entry"
key(Key99001500; "Subc. Prod. Order No.", "Subc. Prod. Order Line No.", "Subc. Purch. Order No.", "Subc. Purch. Order Line No.") { }
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcNotificationMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using System.Environment.Configuration;

#pragma warning disable AS0072, AS0136
codeunit 20506 "Subc. Notification Mgmt."
{
var
Expand Down Expand Up @@ -116,4 +115,3 @@ codeunit 20506 "Subc. Notification Mgmt."
exit('{f7b10c9e-071a-4455-a048-d17b29ef764c}');
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcReportingTriggersExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ using Microsoft.Manufacturing.Reports;
using Microsoft.Manufacturing.Routing;
using Microsoft.Manufacturing.WorkCenter;

#pragma warning disable AS0072, AS0136
codeunit 20512 "Subc. Reporting Triggers Ext"
{
[EventSubscriber(ObjectType::Report, Report::"Detailed Calculation", OnAfterGetRecordRoutingLineOnBeforeCalcRoutingCostPerUnit, '', false, false)]
Expand Down Expand Up @@ -62,4 +61,3 @@ codeunit 20512 "Subc. Reporting Triggers Ext"
IsHandled := true;
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcSessionState.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// ------------------------------------------------------------------------------------------------
namespace Microsoft.Manufacturing.Subcontracting;

#pragma warning disable AS0072, AS0136
codeunit 20500 "Subc. Session State"
{
SingleInstance = true;
Expand Down Expand Up @@ -116,4 +115,3 @@ codeunit 20500 "Subc. Session State"
ReturnRecordID := RecordIDDictionary.Get(StoredKey);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcSynchronizeManagement.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ using Microsoft.Manufacturing.Capacity;
using Microsoft.Manufacturing.Document;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
codeunit 20511 "Subc. Synchronize Management"
{
var
Expand Down Expand Up @@ -279,4 +278,3 @@ codeunit 20511 "Subc. Synchronize Management"
exit(IsSubcontracting);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/General/SubcontractingManagement.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ using Microsoft.Purchases.Document;
using Microsoft.Purchases.Vendor;
using System.Utilities;

#pragma warning disable AS0072, AS0136
codeunit 20505 "Subcontracting Management"
{
var
Expand Down Expand Up @@ -461,4 +460,3 @@ codeunit 20505 "Subcontracting Management"
begin
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcBusinessSetupExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Foundation.Company;
using Microsoft.Manufacturing.Setup;
using System.Environment.Configuration;

#pragma warning disable AS0072, AS0136
codeunit 20502 "Subc. Business Setup Ext."
{
var
Expand All @@ -32,4 +31,3 @@ codeunit 20502 "Subc. Business Setup Ext."
SubcontractingCompInit.CreateBasicSubcontractingMgtSetup();
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcReqWkshTemplUpgrade.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace Microsoft.Manufacturing.Subcontracting;
using Microsoft.Inventory.Requisition;
using System.Upgrade;

#pragma warning disable AS0072, AS0136
codeunit 20572 "Subc. Req Wksh Templ Upgrade"
{
Subtype = Upgrade;
Expand Down Expand Up @@ -67,4 +66,3 @@ codeunit 20572 "Subc. Req Wksh Templ Upgrade"
exit(99001504);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcUpgradeTagDefExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using System.Upgrade;

#pragma warning disable AS0072, AS0136
codeunit 20570 "Subc. Upgrade Tag Def. Ext."
{
[EventSubscriber(ObjectType::Codeunit, Codeunit::"Upgrade Tag", 'OnGetPerCompanyUpgradeTags', '', false, false)]
Expand All @@ -26,4 +25,3 @@ codeunit 20570 "Subc. Upgrade Tag Def. Ext."
exit('MS-644283-SubcReqWkshTemplTypeRenumber-20260803');
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcontractingCompInit.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace Microsoft.Manufacturing.Subcontracting;
using Microsoft.Inventory.Requisition;
using Microsoft.Manufacturing.Setup;

#pragma warning disable AS0072, AS0136
codeunit 20503 "Subcontracting Comp. Init."
{
var
Expand Down Expand Up @@ -88,4 +87,3 @@ codeunit 20503 "Subcontracting Comp. Init."
exit(DefaultCompTransferLeadTimeLbl);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Install/SubcontractingInstall.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using System.Upgrade;

#pragma warning disable AS0072, AS0136
codeunit 20501 "Subcontracting Install"
{
Subtype = Install;
Expand Down Expand Up @@ -74,4 +73,3 @@ codeunit 20501 "Subcontracting Install"
UpgradeTag.SetUpgradeTag(SubcUpgradeTagDefExt.GetSubcontractingUpgradeTag());
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/ComponentSupplyMethod.Enum.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// ------------------------------------------------------------------------------------------------
namespace Microsoft.Manufacturing.Subcontracting;

#pragma warning disable AS0072, AS0136
enum 20500 "Component Supply Method"
{
Extensible = true;
Expand All @@ -29,4 +28,3 @@ enum 20500 "Component Supply Method"
Caption = 'Transfer to Vendor';
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/ComponentsatLocation.Enum.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// ------------------------------------------------------------------------------------------------
namespace Microsoft.Manufacturing.Subcontracting;

#pragma warning disable AS0072, AS0136
enum 20503 "Components at Location"
{
Extensible = true;
Expand All @@ -25,4 +24,3 @@ enum 20503 "Components at Location"
Caption = 'Manufacturing Setup';
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCalcBOMTreeExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.BOM.Tree;
using Microsoft.Inventory.Item;
using Microsoft.Manufacturing.Routing;

#pragma warning disable AS0072, AS0136
codeunit 20521 "Subc. Calc BOM Tree Ext."
{
#if not CLEAN27
Expand Down Expand Up @@ -36,4 +35,3 @@ codeunit 20521 "Subc. Calc BOM Tree Ext."
SubcSessionState.SetRecordID('OnBeforeCalcRoutingLineCosts', ParentItem.RecordId());
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCalcProdOrderExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Manufacturing.Document;
using Microsoft.Manufacturing.ProductionBOM;
using Microsoft.Manufacturing.Routing;

#pragma warning disable AS0072, AS0136
codeunit 20517 "Subc. Calc. Prod. Order Ext."
{
#if not CLEAN28
Expand Down Expand Up @@ -67,4 +66,3 @@ codeunit 20517 "Subc. Calc. Prod. Order Ext."
begin
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCalcStandardCostExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Item;
using Microsoft.Manufacturing.Routing;
using Microsoft.Manufacturing.StandardCost;

#pragma warning disable AS0072, AS0136
codeunit 20514 "Subc. Calc.StandardCost Ext."
{
#if not CLEAN28
Expand Down Expand Up @@ -60,4 +59,3 @@ codeunit 20514 "Subc. Calc.StandardCost Ext."
SubcSessionState.SetDate('OnAfterSetProperties', NewCalculationDate);
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCalcSubcontractsExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Requisition;
using Microsoft.Manufacturing.Document;
using Microsoft.Manufacturing.WorkCenter;

#pragma warning disable AS0072, AS0136
codeunit 20529 "Subc. Calc Subcontracts Ext."
{
[EventSubscriber(ObjectType::Report, Report::"Subc. Calculate Subcontracts", OnAfterTransferProdOrderRoutingLine, '', false, false)]
Expand Down Expand Up @@ -36,4 +35,3 @@ codeunit 20529 "Subc. Calc Subcontracts Ext."
RequisitionLine.Validate("Subc. Standard Task Code", ProdOrderRoutingLine."Standard Task Code");
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCapLEntries.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ using Microsoft.Purchases.Document;
using Microsoft.Purchases.History;
using Microsoft.Utilities;

#pragma warning disable AS0072, AS0136
pageextension 20502 "Subc. CapLEntries" extends "Capacity Ledger Entries"
{
layout
Expand Down Expand Up @@ -89,4 +88,3 @@ pageextension 20502 "Subc. CapLEntries" extends "Capacity Ledger Entries"
var
NoDocumentFoundMsg: Label 'No related document could be found for this entry.';
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCapLedgerEntryExt.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ namespace Microsoft.Manufacturing.Subcontracting;
using Microsoft.Manufacturing.Capacity;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
tableextension 20504 "Subc. Cap Ledger Entry Ext." extends "Capacity Ledger Entry"
{
AllowInCustomizations = AsReadOnly;
Expand All @@ -33,4 +32,3 @@ tableextension 20504 "Subc. Cap Ledger Entry Ext." extends "Capacity Ledger Entr
}
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCarryOutActionExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Planning;
using Microsoft.Inventory.Requisition;
using Microsoft.Manufacturing.Document;

#pragma warning disable AS0072, AS0136
codeunit 20523 "Subc. Carry Out Action Ext."
{
#if not CLEAN27
Expand Down Expand Up @@ -37,4 +36,3 @@ codeunit 20523 "Subc. Carry Out Action Ext."
ProdOrderComponent."Subc. Orig. Bin Code" := PlanningComponent."Orig. Bin Code";
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcCompFactboxMgmt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Ledger;
using Microsoft.Manufacturing.Document;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
codeunit 20562 "Subc. Comp. Factbox Mgmt."
{
#if not CLEAN28
Expand Down Expand Up @@ -226,4 +225,3 @@ codeunit 20562 "Subc. Comp. Factbox Mgmt."
ProdOrderRoutingLine.FindFirst();
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcDispatchingList.Report.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ using System.Email;
using System.Globalization;
using System.Utilities;

#pragma warning disable AS0072, AS0136
report 20504 "Subc. Dispatching List"
{
ApplicationArea = Subcontracting;
Expand Down Expand Up @@ -2023,4 +2022,3 @@ report 20504 "Subc. Dispatching List"
ShptMethodDescTxt := ShptMethodDescLbl;
end;
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcFinishedProdOrder.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Ledger;
using Microsoft.Manufacturing.Document;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
pageextension 20548 "Subc. Finished Prod. Order" extends "Finished Production Order"
{
actions
Expand Down Expand Up @@ -68,4 +67,3 @@ pageextension 20548 "Subc. Finished Prod. Order" extends "Finished Production Or
}
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcFinishedProdOrders.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ using Microsoft.Inventory.Ledger;
using Microsoft.Manufacturing.Document;
using Microsoft.Purchases.Document;

#pragma warning disable AS0072, AS0136
pageextension 20543 "Subc. Finished Prod. Orders" extends "Finished Production Orders"
{
actions
Expand Down Expand Up @@ -63,4 +62,3 @@ pageextension 20543 "Subc. Finished Prod. Orders" extends "Finished Production O
}
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcPlanningComp.PageExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ namespace Microsoft.Manufacturing.Subcontracting;

using Microsoft.Inventory.Planning;

#pragma warning disable AS0072, AS0136
pageextension 20511 "Subc. Planning Comp" extends "Planning Components"
{
layout
Expand All @@ -20,4 +19,3 @@ pageextension 20511 "Subc. Planning Comp" extends "Planning Components"
}
}
}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcPlanningCompExt.Codeunit.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ using Microsoft.Manufacturing.Document;
using Microsoft.Manufacturing.Routing;
using Microsoft.Purchases.Vendor;

#pragma warning disable AS0072, AS0136
codeunit 20522 "Subc. Planning Comp. Ext."
{
#if not CLEAN28
Expand Down Expand Up @@ -119,4 +118,3 @@ codeunit 20522 "Subc. Planning Comp. Ext."
end;

}
#pragma warning restore AS0072, AS0136
2 changes: 0 additions & 2 deletions src/Apps/W1/Subcontracting/App/src/Manufacturing/SubcPlanningCompExt.TableExt.al
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ using Microsoft.Inventory.Location;
using Microsoft.Inventory.Planning;
using Microsoft.Warehouse.Structure;

#pragma warning disable AS0072, AS0136
tableextension 20503 "Subc. Planning Comp Ext." extends "Planning Component"
{
AllowInCustomizations = AsReadOnly;
Expand Down Expand Up @@ -58,4 +57,3 @@ tableextension 20503 "Subc. Planning Comp Ext." extends "Planning Component"
}
}
}
#pragma warning restore AS0072, AS0136
Loading
Loading