Skip to content

windows/386: enable systemcrypto support #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Quim Muntal (qmuntal) merged 3 commits into from
Aug 21, 2026
+129 −60
Merged

windows/386: enable systemcrypto support #2465

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
652ace7
windows/386: enable systemcrypto support
qmuntal Aug 20, 2026
a24ec93
Trigger Azure Pipelines
qmuntal Aug 21, 2026
3ce9ed7
eng/pipeline: fix MinGW architecture selection
qmuntal Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eng/doc/SupportedPlatforms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Platforms outside this scope are supported on a best-effort basis with no guaran
| linux/amd64 | Azure Linux 3.0, Ubuntu 22.04 |
| linux/arm64 | Azure Linux 3.0, Ubuntu 22.04 |
| linux/arm | Ubuntu 22.04 |
| windows/386 | Windows 10, Windows Server 2016 (since Go 1.28) |
| windows/amd64 | Windows 10, Windows Server 2016 |
| windows/arm64 | Windows 11, Windows Server 2025 |

Expand Down
6 changes: 4 additions & 2 deletions eng/pipeline/stages/go-builder-matrix-stages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,9 @@ stages:
# Could be determined based on inputs (if more are added) but the caller can just tell us.
- ${{ if parameters.buildandpack }}:
- { os: linux, arch: amd64, config: buildandpack }
- { os: windows, arch: amd64, config: buildandpack }
- { os: linux, arch: arm, hostArch: amd64, config: buildandpack }
- { os: linux, arch: arm64, hostArch: amd64, config: buildandpack }
- { os: windows, arch: amd64, config: buildandpack }
- { os: windows, arch: arm64, hostArch: amd64, config: buildandpack }
- { os: darwin, arch: amd64, config: buildandpack }
- { os: darwin, arch: arm64, config: buildandpack }
Expand Down Expand Up @@ -102,11 +102,13 @@ stages:
- { os: linux, arch: amd64, config: nocgo, distro: azurelinux3, fips: true }
- { nosystemcrypto: true, os: windows, arch: amd64, config: devscript }
- { nosystemcrypto: true, os: windows, arch: amd64, config: test }
- { nosystemcrypto: true, os: windows, arch: 386, hostArch: amd64, config: test }
- { os: windows, arch: amd64, config: test }
- { os: windows, arch: amd64, config: test, fips: true }
- { os: windows, arch: 386, hostArch: amd64, config: test }
- { experiment: ms_tls_config_schannel, os: windows, arch: amd64, config: test }
# Test that buildandpack works on Windows x86-32, but don't release it.
- { nosystemcrypto: true, os: windows, hostArch: amd64, arch: 386, config: buildandpack }
- { os: windows, arch: 386, hostArch: amd64, config: buildandpack }
- ${{ if parameters.outerloop }}:
# Upstream builders.
# - { nosystemcrypto: true, os: linux, arch: amd64, config: clang } https://github.com/microsoft/go/issues/342
Expand Down
6 changes: 5 additions & 1 deletion eng/pipeline/stages/run-stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ stages:

- pwsh: |
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw diagnose
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run -ci azdo -source nixman -version 13.2.0-rt_v11-rev0 -arch x86_64 -threading posix -exception seh -runtime msvcrt
if ('${{ parameters.builder.arch }}' -eq '386') {
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run -ci azdo -source nixman -version 13.2.0-rt_v11-rev0 -arch i686 -threading posix -exception dwarf -runtime msvcrt
} else {
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run -ci azdo -source nixman -version 13.2.0-rt_v11-rev0 -arch x86_64 -threading posix -exception seh -runtime msvcrt
}
displayName: Install MinGW

# Build. This includes retry logic internally if necessary for this builder.
Expand Down
Loading