windows/386: enable systemcrypto support - #2465
Merged
Quim Muntal (qmuntal) merged 3 commits intoAug 21, 2026
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Enables systemcrypto support by default on windows/386, adds CI coverage to validate Windows 386 with and without systemcrypto, and documents Windows 386 as a supported platform starting with Go 1.28.
Changes:
- Expand
internal/platform.SystemCryptoSupported(via patch) to include Windows as systemcrypto-capable, and update systemcrypto tests accordingly. - Add Azure DevOps matrix entries to test windows/386 both with and without systemcrypto, and build the windows/386 distribution with systemcrypto enabled.
- Update supported-platform documentation to include windows/386 (since Go 1.28).
Show a summary per file
| File | Description |
|---|---|
| patches/0002-Add-crypto-backends.patch | Updates the systemcrypto support predicate (including Windows) and adjusts systemcrypto tests within the patch payload. |
| eng/pipeline/stages/go-builder-matrix-stages.yml | Adds windows/386 CI coverage with/without systemcrypto and enables systemcrypto for the windows/386 buildandpack job. |
| eng/doc/SupportedPlatforms.md | Documents windows/386 support starting in Go 1.28. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Lite
Quim Muntal (qmuntal)
force-pushed
the
dev/qmuntal/windows-386-systemcrypto
branch
2 times, most recently
from
August 20, 2026 14:02
e99d3b3 to
63379ed
Compare
George Adams (gdams)
approved these changes
Aug 20, 2026
Quim Muntal (qmuntal)
enabled auto-merge
August 20, 2026 14:25
George Adams (gdams)
disabled auto-merge
August 20, 2026 15:21
Quim Muntal (qmuntal)
force-pushed
the
dev/qmuntal/windows-386-systemcrypto
branch
from
August 20, 2026 16:11
63379ed to
652ace7
Compare
Member
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Member
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Quim Muntal (qmuntal)
enabled auto-merge
August 20, 2026 20:52
Member
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
George Adams (gdams)
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing