Parameterize getmingw call rather than duplicate long line - #2470
Open
Davis Goodin (dagood) wants to merge 1 commit into
Open
Parameterize getmingw call rather than duplicate long line#2470Davis Goodin (dagood) wants to merge 1 commit into
Davis Goodin (dagood) wants to merge 1 commit into
Conversation
Davis Goodin (dagood)
commented
Aug 21, 2026
Davis Goodin (dagood)
commented
Member
- Patch recent change windows/386: enable systemcrypto support #2465
- Avoid duplicating for maintainability and readability.
- Chop long line for readability.
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the Windows “Install MinGW” pipeline step to avoid duplicating a long getmingw run invocation, improving maintainability and readability in the Azure DevOps stage template.
Changes:
- Introduces PowerShell variables (
$arch,$exception) derived fromparameters.builder.arch. - Consolidates the duplicated
getmingw runcommand into a single invocation using those variables. - Splits the long command across multiple lines with PowerShell line continuations for readability.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| } | ||
| eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run ` | ||
| -ci azdo ` | ||
| -source nixman -version 13.2.0-rt_v11-rev0 ` |
There was a problem hiding this comment.
Do we externalize version #?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.