Skip to content

Parameterize getmingw call rather than duplicate long line #2470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Davis Goodin (dagood) wants to merge 1 commit into
base: microsoft/main
Choose a base branch
from
+8 −2
Open

Parameterize getmingw call rather than duplicate long line #2470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions eng/pipeline/stages/run-stage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,10 +230,16 @@ stages:
- pwsh: |
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw diagnose
if ('${{ parameters.builder.arch }}' -eq '386') {
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run -ci azdo -source nixman -version 13.2.0-rt_v11-rev0 -arch i686 -threading posix -exception dwarf -runtime msvcrt
$arch = 'i686'
$exception = 'dwarf'
} else {
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run -ci azdo -source nixman -version 13.2.0-rt_v11-rev0 -arch x86_64 -threading posix -exception seh -runtime msvcrt
$arch = 'x86_64'
$exception = 'seh'
}
eng/run.ps1 go run github.com/microsoft/go-infra/cmd/getmingw run `
-ci azdo `
-source nixman -version 13.2.0-rt_v11-rev0 `

@karianna Martijn Verburg (karianna) Aug 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we externalize version #?

-arch $arch -threading posix -exception $exception -runtime msvcrt
displayName: Install MinGW

# Build. This includes retry logic internally if necessary for this builder.
Expand Down