fix: call strip() with parentheses to properly check whitespace-only vector store URIs (fixes #2381)#2383
Open
hanhan761 wants to merge 2 commits into
Open
fix: call strip() with parentheses to properly check whitespace-only vector store URIs (fixes #2381)#2383hanhan761 wants to merge 2 commits into
hanhan761 wants to merge 2 commits into
Conversation
…vector store URIs (fixes microsoft#2381)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug where store.db_uri.strip == "" always evaluates to False because .strip is used without parentheses, returning a bound method reference instead of the trimmed string. This prevents the default vector store URI from being applied when the configured URI is whitespace-only.
Changes
Issue
Fixes #2381
Verification
ot store.db_uri still handles None/empty string on the short-circuit before .strip() is called