Skip to content

fix: call strip() with parentheses to properly check whitespace-only vector store URIs (fixes #2381) #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hanhan761 wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −2
Open

fix: call strip() with parentheses to properly check whitespace-only vector store URIs (fixes #2381) #2383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0575f77
fix: preserve entities without community assignment in community leve…
hanhan761 May 30, 2026
c32cca2
fix: call strip() with parentheses to properly check whitespace-only …
hanhan761 May 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/graphrag/graphrag/config/models/graph_rag_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def _validate_vector_store_db_uri(self) -> None:
"""Validate the vector store configuration."""
store = self.vector_store
if store.type == VectorStoreType.LanceDB:
if not store.db_uri or store.db_uri.strip == "":
if not store.db_uri or store.db_uri.strip() == "":
store.db_uri = graphrag_config_defaults.vector_store.db_uri
store.db_uri = str(Path(store.db_uri).resolve())

Expand Down
11 changes: 10 additions & 1 deletion packages/graphrag/graphrag/query/indexer_adapters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,16 @@ def embed_community_reports(
def _filter_under_community_level(
df: pd.DataFrame, community_level: int
) -> pd.DataFrame:
nan_count = df.level.isna().sum()
if nan_count > 0:
orphan_pct = nan_count / len(df) * 100
if orphan_pct > 10:
logger.warning(
"%.0f%% of entities have no community assignment. "
"Consider checking your community detection settings.",
orphan_pct,
)
return cast(
"pd.DataFrame",
df[df.level <= community_level],
df[(df.level <= community_level) | df.level.isna()],
)