fix: isCuMemMapAllocated crashes on non-NVLS systems even with MSCCLPP_FORCE_DISABLE_NVLS=true#790
Merged
Conversation
…sSupported caching Agent-Logs-Url: https://github.com/microsoft/mscclpp/sessions/f8417c19-e697-4a32-a298-9a958b9a16a1 Co-authored-by: Binyang2014 <9415966+Binyang2014@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix RuntimeError for MSCCLPP on Perlmutter A100 GPUs
fix: isCuMemMapAllocated crashes on non-NVLS systems even with MSCCLPP_FORCE_DISABLE_NVLS=true
Apr 20, 2026
Binyang2014
reviewed
Apr 20, 2026
…IP env Agent-Logs-Url: https://github.com/microsoft/mscclpp/sessions/dc2eb9a6-b5e4-4daf-8c7d-c6eac8223dff Co-authored-by: Binyang2014 <9415966+Binyang2014@users.noreply.github.com>
Contributor
|
/azp run mscclpp-ut |
|
Azure Pipelines successfully started running 1 pipeline(s). |
chhwang
approved these changes
Apr 22, 2026
Binyang2014
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isCuMemMapAllocated()to just returntrue/falsewithout throwing when NVLS is not supportedisNvlsSupported()caching bug whereresult/isCheckedwere never updated[[maybe_unused]]onresultandisCheckedstatics — needed in HIP/ROCm env whereCUDA_NVLS_API_AVAILABLEis not defined and the variables would otherwise be unused./tools/lint.sh)