Skip to content

fix: isCuMemMapAllocated crashes on non-NVLS systems even with MSCCLPP_FORCE_DISABLE_NVLS=true #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Binyang2014 merged 3 commits into from
Apr 22, 2026
Merged

fix: isCuMemMapAllocated crashes on non-NVLS systems even with MSCCLPP_FORCE_DISABLE_NVLS=true #790

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc2a66c
Initial plan
Copilot Apr 20, 2026
7a50870
fix: remove NVLS support check from isCuMemMapAllocated and fix isNvl…
Copilot Apr 20, 2026
6d64528
fix: restore [[maybe_unused]] on static vars in isNvlsSupported for H…
Copilot Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions src/core/gpu_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,8 @@ bool isNvlsSupported() {
if (env()->forceDisableNvls) {
return false;
}
[[maybe_unused]] static bool result = false;
[[maybe_unused]] static bool isChecked = false;
static bool result = false;
Comment thread
Binyang2014 marked this conversation as resolved.
Outdated
static bool isChecked = false;
#if (CUDA_NVLS_API_AVAILABLE)
if (!isChecked) {
int deviceId;
Expand All @@ -283,7 +283,9 @@ bool isNvlsSupported() {
MSCCLPP_CUDATHROW(cudaGetDevice(&deviceId));
MSCCLPP_CUTHROW(cuDeviceGet(&dev, deviceId));
MSCCLPP_CUTHROW(cuDeviceGetAttribute(&isMulticastSupported, CU_DEVICE_ATTRIBUTE_MULTICAST_SUPPORTED, dev));
return isMulticastSupported == 1;
result = (isMulticastSupported == 1);
isChecked = true;
return result;
}
return result;
#endif
Expand All @@ -300,9 +302,6 @@ bool isCuMemMapAllocated([[maybe_unused]] void* ptr) {
return false;
}
MSCCLPP_CUTHROW(cuMemRelease(handle));
if (!isNvlsSupported()) {
Comment thread
Binyang2014 marked this conversation as resolved.
throw Error("cuMemMap is used in env without NVLS support", ErrorCode::InvalidUsage);
}
return true;
#endif
}
Expand Down
Loading