Skip to content

[pbi-fixer] Add fix_do_not_summarize: set SummarizeBy=None on numeric columns - #1203

Open
KornAlexander wants to merge 3 commits into
microsoft:mainfrom
KornAlexander:feature/fix-do-not-summarize
Open

[pbi-fixer] Add fix_do_not_summarize: set SummarizeBy=None on numeric columns#1203
KornAlexander wants to merge 3 commits into
microsoft:mainfrom
KornAlexander:feature/fix-do-not-summarize

Conversation

@KornAlexander

Copy link
Copy Markdown

Adds a sempy_labs fixer fix_do_not_summarize() that set SummarizeBy=None on key/ID numeric columns.

Adds one source file (src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py) plus one re-export line in the matching __init__.py. No other files touched, no shared helpers, no dependency on any other PR.

Part of the PBI Fixer contribution. Tracking issue: #1185

Copilot AI review requested due to automatic review settings May 5, 2026 12:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new semantic-model “fixer” function, fix_do_not_summarize(), intended to update numeric columns so Power BI won’t implicitly aggregate them, and re-exports it from sempy_labs.semantic_model.

Changes:

  • Added fix_do_not_summarize() implementation in a new standalone module.
  • Re-exported fix_do_not_summarize from sempy_labs.semantic_model.__init__.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py Adds the new fixer that scans columns and attempts to set SummarizeBy to “None”.
src/sempy_labs/semantic_model/init.py Re-exports fix_do_not_summarize via __all__.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py Outdated
Comment thread src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py
Comment thread src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py
Comment thread src/sempy_labs/semantic_model/_Fix_DoNotSummarize.py Outdated
@KornAlexander KornAlexander changed the title [pbi-fixer] Add fix_do_not_summarize: set SummarizeBy=None on key/ID numeric columns [pbi-fixer] Add fix_do_not_summarize: set SummarizeBy=None on numeric columns May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants