-
Notifications
You must be signed in to change notification settings - Fork 190
[pbi-fixer] Add fix_do_not_summarize: set SummarizeBy=None on numeric columns #1203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
KornAlexander
wants to merge
3
commits into
microsoft:main
Choose a base branch
from
KornAlexander:feature/fix-do-not-summarize
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| # Fix "Do not summarize numeric columns" — standalone BPA fixer. | ||
| # Sets SummarizeBy to None on all numeric data columns. | ||
|
|
||
| from typing import Optional | ||
| from uuid import UUID | ||
|
|
||
|
|
||
| def fix_do_not_summarize( | ||
| dataset: str, | ||
| workspace: Optional[str | UUID] = None, | ||
| scan_only: bool = False, | ||
| ): | ||
|
KornAlexander marked this conversation as resolved.
Outdated
|
||
| """ | ||
| Sets SummarizeBy to None on numeric data columns. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| dataset : str | ||
| Name of the semantic model. | ||
| workspace : str | uuid.UUID, default=None | ||
| The Fabric workspace name or ID. | ||
| scan_only : bool, default=False | ||
| If True, only reports what would be fixed without making changes. | ||
| """ | ||
| from sempy_labs.tom import connect_semantic_model | ||
|
|
||
| fixed = 0 | ||
| with connect_semantic_model(dataset=dataset, readonly=scan_only, workspace=workspace) as tom: | ||
| import Microsoft.AnalysisServices.Tabular as TOM | ||
|
|
||
| for table in tom.model.Tables: | ||
| for col in table.Columns: | ||
| if col.Type != TOM.ColumnType.Data: | ||
| continue | ||
| if col.DataType not in (TOM.DataType.Int64, TOM.DataType.Double, TOM.DataType.Decimal): | ||
| continue | ||
|
KornAlexander marked this conversation as resolved.
|
||
| if str(col.SummarizeBy) == "None": | ||
| continue | ||
| if scan_only: | ||
| print(f" Would fix: '{table.Name}'[{col.Name}] SummarizeBy={col.SummarizeBy} → None") | ||
| else: | ||
| col.SummarizeBy = TOM.AggregateFunction.Default # None | ||
| try: | ||
| col.SummarizeBy = getattr(TOM.AggregateFunction, "None_", TOM.AggregateFunction.Default) | ||
| except Exception: | ||
| pass | ||
|
KornAlexander marked this conversation as resolved.
Outdated
|
||
| print(f" Fixed: '{table.Name}'[{col.Name}] → SummarizeBy=None") | ||
| fixed += 1 | ||
| if not scan_only and fixed > 0: | ||
| tom.model.SaveChanges() | ||
|
|
||
| action = "Would fix" if scan_only else "Fixed" | ||
| print(f" {action} {fixed} column(s).") | ||
| return fixed | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.