feat: add synchronous LoadCollection warmup option - #3786
Conversation
Signed-off-by: sunby <sunbingyi1992@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunby The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3786 +/- ##
=======================================
Coverage 94.22% 94.22%
=======================================
Files 77 77
Lines 16204 16210 +6
=======================================
+ Hits 15268 15274 +6
Misses 936 936 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Tick the box to add this pull request to the merge queue (same as
|
Summary
Add explicit
warmup="sync"handling to the sharedLoadCollectionrequest builder used by synchronous and asynchronous handlers.LoadCollectionRequest.load_params["warmup"] = "sync".refresh/_refresh.This is a clean, single-commit PR based on upstream
master(a4b3b38b): onlypymilvus/client/prepare.pyandtests/unit/test_load_warmup.pychange, with 37 added lines. The fork's namespace commits and local protobuf submodule changes are not included.References
Validation
Verified in an isolated checkout of this upstream-based commit:
pytest tests/unit/prepare/test_collection.py tests/unit/test_load_warmup.py -q: 73 passed, including all 10 new warmup cases.git diff --checkpassed.Release boundary
Keep this PR as Draft pending the corresponding server support and SDK/server E2E acceptance. Request serialization and validation are tested; actual synchronous cache warmup is not verified by these tests. The proposed server feature gate remains disabled by default. This SDK change does not negotiate capabilities and cannot guarantee warmup on older or otherwise unsupported servers.