feat: add synchronous LoadCollection warmup option - #1
Closed
sunby wants to merge 1 commit into
Closed
Conversation
Signed-off-by: sunby <sunbingyi1992@gmail.com>
This was referenced Sep 8, 2026
Owner
Author
|
Superseded by milvus-io#3786, targeting the official repository. The replacement is based on upstream master and contains only the warmup request-builder change and tests, excluding the fork namespace commits. The original branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode explicit
warmup="sync"inLoadCollectionRequest.load_params.load_paramsunchanged when the option is omitted.refresh/_refresh.References and scope
sunby/pymilvus:fix-namespace-requests; onlypymilvus/client/prepare.pyandtests/unit/test_load_warmup.pyare included. The local protobuf submodule change is excluded.Verification
PYTHONPATH=. .venv/bin/python -m pytest tests/unit/test_load_warmup.py -q: 10 passed.git diff --checkpassed.Draft to accompany the server feature: request serialization is verified, but actual synchronous warmup and SDK/server E2E are pending. The server feature gate remains disabled by default; this SDK option alone is not evidence that a deployed server supports the requested behavior.