Skip to content

feat: add synchronous LoadCollection warmup option - #1

Closed
sunby wants to merge 1 commit into
fix-namespace-requestsfrom
codex/load-collection-force-sync-warmup
Closed

feat: add synchronous LoadCollection warmup option#1
sunby wants to merge 1 commit into
fix-namespace-requestsfrom
codex/load-collection-force-sync-warmup

Conversation

@sunby

@sunby sunby commented Sep 8, 2026

Copy link
Copy Markdown
Owner

Summary

Encode explicit warmup="sync" in LoadCollectionRequest.load_params.

  • Leave load_params unchanged when the option is omitted.
  • Reject unsupported values and explicit sync together with refresh / _refresh.
  • Preserve the existing namespace, load-priority and other load options.

References and scope

Verification

  • PYTHONPATH=. .venv/bin/python -m pytest tests/unit/test_load_warmup.py -q: 10 passed.
  • Ruff check and format check passed for both changed files.
  • git diff --check passed.

Draft to accompany the server feature: request serialization is verified, but actual synchronous warmup and SDK/server E2E are pending. The server feature gate remains disabled by default; this SDK option alone is not evidence that a deployed server supports the requested behavior.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby

sunby commented Sep 8, 2026

Copy link
Copy Markdown
Owner Author

Superseded by milvus-io#3786, targeting the official repository. The replacement is based on upstream master and contains only the warmup request-builder change and tests, excluding the fork namespace commits. The original branch is retained.

@sunby sunby closed this Sep 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant