Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions pymilvus/client/prepare.py
Original file line number Diff line number Diff line change
Expand Up @@ -2118,6 +2118,13 @@ def load_collection(
priority = kwargs.get("priority")
req.load_params["load_priority"] = priority

if "warmup" in kwargs:
if kwargs["warmup"] != "sync":
raise ParamError(message="load parameter warmup only supports sync")
if req.refresh:
raise ParamError(message="load parameter warmup cannot be used with refresh")
req.load_params["warmup"] = "sync"

return req

@classmethod
Expand Down
30 changes: 30 additions & 0 deletions tests/unit/test_load_warmup.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import pytest
from pymilvus.client.prepare import Prepare
from pymilvus.exceptions import ParamError


def test_load_sync_warmup_preserves_other_options():
request = Prepare.load_collection(
"warmup_test", replica_number=2, warmup="sync", load_fields=["id"], priority="HIGH"
)
assert request.load_params["warmup"] == "sync"
assert request.load_params["load_priority"] == "HIGH"
assert request.replica_number == 2
assert list(request.load_fields) == ["id"]


def test_load_without_warmup_keeps_existing_semantics():
assert "warmup" not in Prepare.load_collection("warmup_test").load_params
assert Prepare.load_collection("warmup_test", refresh=True).refresh


@pytest.mark.parametrize("warmup", ["disable", "async", "", None, True, 1])
def test_load_rejects_unsupported_warmup(warmup):
with pytest.raises(ParamError, match="only supports sync"):
Prepare.load_collection("warmup_test", warmup=warmup)


@pytest.mark.parametrize("refresh_key", ["refresh", "_refresh"])
def test_load_sync_warmup_rejects_refresh(refresh_key):
with pytest.raises(ParamError, match="cannot be used with refresh"):
Prepare.load_collection("warmup_test", warmup="sync", **{refresh_key: True})