fix: align membership builder docs and tests with membership_match syntax - #3792
Open
CodeAlex52 wants to merge 1 commit into
Open
fix: align membership builder docs and tests with membership_match syntax#3792CodeAlex52 wants to merge 1 commit into
CodeAlex52 wants to merge 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: CodeAlex52 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @CodeAlex52! It looks like this is your first PR to milvus-io/pymilvus 🎉 |
…ntax Signed-off-by: CodeAlex52 <59381946+CodeAlex52@users.noreply.github.com>
CodeAlex52
force-pushed
the
docs-membership-match-syntax
branch
from
September 10, 2026 05:45
99f2f02 to
6f4a703
Compare
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3787
The server now exposes only membership_match and rejects the predecessor names bloom_match and roaring_match, but the SDK docstrings and mocked plumbing tests still taught the old names. This updates the build_bloom_filter, RoaringBitmapBuilder, and build_roaring_bitmap docstrings plus the two request-plumbing test expressions to membership_match. Builder API names and wire formats are unchanged.
Tests: pytest tests/unit/test_roaring_filter.py, 183 passed. Ruff check and format clean. No live server was available, so the server-backed check from the issue is not included.