Skip to content

fix: align membership builder docs and tests with membership_match syntax - #3792

Open
CodeAlex52 wants to merge 1 commit into
milvus-io:masterfrom
CodeAlex52:docs-membership-match-syntax
Open

fix: align membership builder docs and tests with membership_match syntax#3792
CodeAlex52 wants to merge 1 commit into
milvus-io:masterfrom
CodeAlex52:docs-membership-match-syntax

Conversation

@CodeAlex52

Copy link
Copy Markdown

Fixes #3787

The server now exposes only membership_match and rejects the predecessor names bloom_match and roaring_match, but the SDK docstrings and mocked plumbing tests still taught the old names. This updates the build_bloom_filter, RoaringBitmapBuilder, and build_roaring_bitmap docstrings plus the two request-plumbing test expressions to membership_match. Builder API names and wire formats are unchanged.

Tests: pytest tests/unit/test_roaring_filter.py, 183 passed. Ruff check and format clean. No live server was available, so the server-backed check from the issue is not included.

@sre-ci-robot

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: CodeAlex52
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot

Copy link
Copy Markdown

Welcome @CodeAlex52! It looks like this is your first PR to milvus-io/pymilvus 🎉

…ntax

Signed-off-by: CodeAlex52 <59381946+CodeAlex52@users.noreply.github.com>
@mergify mergify Bot added the needs-dco label Sep 10, 2026
@CodeAlex52
CodeAlex52 force-pushed the docs-membership-match-syntax branch from 99f2f02 to 6f4a703 Compare September 10, 2026 05:45
@mergify mergify Bot added dco-passed and removed needs-dco labels Sep 10, 2026
@mergify

mergify Bot commented Sep 10, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Align membership builder docs and tests with membership_match syntax

2 participants