Skip to content

fix: align membership builder docs and tests with membership_match syntax #3792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CodeAlex52 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: align membership builder docs and tests with membership_match syntax #3792

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pymilvus/client/bloom_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,7 +464,7 @@ def build(self) -> bytes:


def build_bloom_filter(members: Sequence[Union[int, str]], fpr: float = _DEFAULT_FPR) -> bytes:
"""Build an MBF1-wrapped Parquet Split-Block Bloom filter for bloom_match.
"""Build an MBF1-wrapped Parquet Split-Block Bloom filter for membership_match.

Integer members target INT8/INT16/INT32/INT64 fields; string members target
VARCHAR fields. The returned bytes are passed through ``filter_params``.
Expand Down
4 changes: 2 additions & 2 deletions pymilvus/client/roaring_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ class RoaringBitmapBuilder:
builder.add_int64_batch(chunk)
blob = builder.build()

Build the bitmap from the SAME value domain as the target field: ``roaring_match`` matches
Build the bitmap from the SAME value domain as the target field: ``membership_match`` matches
INT8/INT16/INT32/INT64 fields, and a narrow member is sign-extended, so ``INT8(-1)`` and
``-1`` are the same member.
"""
Expand Down Expand Up @@ -519,7 +519,7 @@ def build(self) -> bytes:


def build_roaring_bitmap(members: Sequence[int]) -> bytes:
"""Build an MRB1-wrapped portable Roaring64 bitmap for roaring_match.
"""Build an MRB1-wrapped portable Roaring64 bitmap for membership_match.

Members are signed integers targeting an INT8/INT16/INT32/INT64 field, in any order and with
any number of duplicates. The returned bytes are passed through ``filter_params``, and are
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_roaring_filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -812,7 +812,7 @@ def test_roaring_blob_reaches_the_wire_through_the_public_client(mock_grpc_handl
parsing; that happens after the request is sent, and the request is what is under test here.
"""
blob = build_roaring_bitmap([1, -1, 1 << 40])
expr = "roaring_match(id, {rb})"
expr = "membership_match(id, {rb})"

with patch("pymilvus.orm.connections.GrpcHandler", return_value=mock_grpc_handler), patch(
"pymilvus.client.grpc_handler.GrpcHandler", return_value=mock_grpc_handler
Expand Down Expand Up @@ -848,7 +848,7 @@ def test_roaring_blob_reaches_the_wire_through_the_public_client(mock_grpc_handl
def test_roaring_blob_reaches_query_search_and_delete_requests():
"""The blob must arrive as protobuf bytes -- not base64, not a string -- on every path."""
blob = build_roaring_bitmap([1, -1, 1 << 40])
expr = "roaring_match(id, {rb})"
expr = "membership_match(id, {rb})"

query = Prepare.query_request("coll", expr, [], None, expr_params={"rb": blob})
delete = Prepare.delete_request("coll", expr, None, 0, expr_params={"rb": blob})
Expand Down