Make OidcSession strict-mode safe#3
Merged
Conversation
SidManager mass-assigns revoked_at (firstOrCreate, and invalidate's update), but it was missing from $fillable — so apps that enable Model::shouldBeStrict() (preventSilentlyDiscardingAttributes) hit a MassAssignmentException that 500s the /oauth/authorize flow. Add revoked_at to $fillable and cover it with a regression test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Consumer apps that enable
Model::shouldBeStrict()(which turns onpreventSilentlyDiscardingAttributes) hit aMassAssignmentExceptionthat 500s the/oauth/authorizeflow.SidManagermass-assignsrevoked_atin two places —OidcSession::firstOrCreate([... 'revoked_at' => null], ...)andinvalidate()'s->update(['revoked_at' => now()])— butrevoked_atwas only in$casts, not$fillable. Under default Eloquent it's silently dropped; under strict mode it throws.Fix
revoked_attoOidcSession::$fillable.OidcSessionwithModel::preventSilentlyDiscardingAttributes()enabled no longer throws.Full suite green (70 tests).