Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/Session/OidcSession.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,15 @@ class OidcSession extends Model
use HasUuids;
public $timestamps = false;
protected $table = 'oidc_sessions';
protected $fillable = ['user_id', 'client_id', 'laravel_session_id', 'auth_time', 'created_at', 'last_seen_at'];
protected $fillable = [
'user_id',
'client_id',
'laravel_session_id',
'auth_time',
'created_at',
'last_seen_at',
'revoked_at',
];
protected $casts = [
'auth_time' => 'datetime',
'created_at' => 'datetime',
Expand Down
49 changes: 49 additions & 0 deletions tests/Unit/Session/OidcSessionStrictModeTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?php declare(strict_types=1);

namespace Mindtwo\LaravelIdentity\Tests\Unit\Session;

use Illuminate\Database\Eloquent\Model;
use Mindtwo\LaravelIdentity\Session\OidcSession;
use Mindtwo\LaravelIdentity\Tests\TestCase;

/**
* SidManager mass-assigns `revoked_at` (firstOrCreate with revoked_at => null, and
* update(['revoked_at' => now()])). Consumer apps that enable Model::shouldBeStrict()
* turn on preventSilentlyDiscardingAttributes, which would throw a MassAssignmentException
* and 500 the /oauth/authorize flow unless `revoked_at` is fillable.
*/
class OidcSessionStrictModeTest extends TestCase
{
public function test_oidc_session_can_be_created_and_revoked_under_strict_mode(): void
{
$session = OidcSession::create([
'user_id' => '1',
'client_id' => 'client-1',
'laravel_session_id' => 'session-1',
'auth_time' => now(),
'created_at' => now(),
'last_seen_at' => now(),
'revoked_at' => null,
]);

$this->assertNull($session->revoked_at);

$session->update(['revoked_at' => now()]);

$this->assertNotNull($session->fresh()->revoked_at);
}

protected function setUp(): void
{
parent::setUp();

Model::preventSilentlyDiscardingAttributes();
}

protected function tearDown(): void
{
Model::preventSilentlyDiscardingAttributes(false);

parent::tearDown();
}
}
Loading