fix: bitmap scaling integer division crash on high-DPI devices#150
Open
mostafizurhimself wants to merge 2 commits into
Open
fix: bitmap scaling integer division crash on high-DPI devices#150mostafizurhimself wants to merge 2 commits into
mostafizurhimself wants to merge 2 commits into
Conversation
added 2 commits
June 10, 2026 09:15
…screens pixelWidth / w * h uses integer division which rounds to 0 when imageWidth > pixelWidth (e.g. ViewShot on 2x/3x DPI device captures wider than target pixelWidth). Bitmap.createScaledBitmap with height=0 throws IllegalArgumentException. Fix: use long arithmetic (pixelWidth.toLong() * h / w).toInt() to preserve precision.
…compatibility - Remove 'prepare' script (bob build fails without yarn in git-dep install) - Remove lib/ from .gitignore so built output ships with the package - Add ignoreDeprecations 6.0 and exclude __tests__ from tsconfig.build.json - lib/commonjs, lib/module, lib/typescript all committed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On high-DPI Android devices (2×/3× screen density),
printBitmapBase64andprintBitmapBase64Customcrash with anIllegalArgumentExceptionfromBitmap.createScaledBitmap.Root cause: Integer division truncation.