Skip to content

fix: bitmap scaling integer division crash on high-DPI devices #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mostafizurhimself wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: bitmap scaling integer division crash on high-DPI devices #150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d56efc
fix: integer division causing crash when printing bitmap on high-DPI …
Jun 10, 2026
ba868f4
build: commit lib/ output and remove prepare script for pnpm git-dep …
Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,5 +77,4 @@ android/keystores/debug.keystore
# Turborepo
.turbo/

# generated by bob
lib/
# generated by bob (removed: lib/ committed so pnpm git-dep install works without yarn/bob)
6 changes: 4 additions & 2 deletions android/src/main/java/com/sunmiprinterlibrary/SunmiPrinterLibraryModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -560,7 +560,8 @@ class SunmiPrinterLibraryModule(reactContext: ReactApplicationContext) :
val decodedBitmap = BitmapFactory.decodeByteArray(decodedBytes, 0, decodedBytes.size)
val w = decodedBitmap.width
val h = decodedBitmap.height
val image = Bitmap.createScaledBitmap(decodedBitmap, pixelWidth, pixelWidth / w * h, false)
val scaledHeight = (pixelWidth.toLong() * h / w).toInt()
val image = Bitmap.createScaledBitmap(decodedBitmap, pixelWidth, scaledHeight, false)
printerService?.printBitmap(image, callback)
} catch (e: Exception) {
promise.reject("0", "native#printBitmapBase64 is failed. " + e.message)
Expand All @@ -577,7 +578,8 @@ class SunmiPrinterLibraryModule(reactContext: ReactApplicationContext) :
val decodedBitmap = BitmapFactory.decodeByteArray(decodedBytes, 0, decodedBytes.size)
val w = decodedBitmap.width
val h = decodedBitmap.height
val image = Bitmap.createScaledBitmap(decodedBitmap, pixelWidth, pixelWidth / w * h, false)
val scaledHeight = (pixelWidth.toLong() * h / w).toInt()
val image = Bitmap.createScaledBitmap(decodedBitmap, pixelWidth, scaledHeight, false)
printerService?.printBitmapCustom(image, type, callback)
} catch (e: Exception) {
promise.reject("0", "native#printBitmapBase64Custom is failed. " + e.message)
Expand Down
Loading