Add SE and MAE support#351
Open
TuomasBorman wants to merge 5 commits into
Open
Conversation
TuomasBorman
commented
Feb 12, 2025
| person("Florian", "Rohart", role = "aut"), | ||
| person("Ignacio", "Gonzalez", role = "aut"), | ||
| person("Sebastien", "Dejean", role = "aut"), | ||
| ## key contributors |
Author
There was a problem hiding this comment.
Comments are not supported, and they lead to an error
TuomasBorman
commented
Feb 12, 2025
Comment on lines
+220
to
+294
| setMethod("mixOmics", signature = c(X = "matrix"), function( | ||
| X, | ||
| Y, | ||
| indY, | ||
| study, | ||
| ncomp, | ||
| keepX, | ||
| keepY, | ||
| design, | ||
| tau = NULL, | ||
| mode = c("regression", "canonical", "invariant", "classic"), | ||
| scale, | ||
| tol = 1e-06, | ||
| max.iter = 100, | ||
| near.zero.var = FALSE){ | ||
| res <- internal_mixOmics( | ||
| X, | ||
| Y, | ||
| indY, | ||
| study, | ||
| ncomp, | ||
| keepX, | ||
| keepY, | ||
| design, | ||
| tau = NULL, | ||
| mode = c("regression", "canonical", "invariant", "classic"), | ||
| scale, | ||
| tol = 1e-06, | ||
| max.iter = 100, | ||
| near.zero.var = FALSE | ||
| ) | ||
| return(res) | ||
| } | ||
| ) | ||
|
|
||
| #' @rdname mixOmics | ||
| #' @export | ||
| setMethod("mixOmics", signature = c(X = "list"), function( | ||
| X, | ||
| Y, | ||
| indY, | ||
| study, | ||
| ncomp, | ||
| keepX, | ||
| keepY, | ||
| design, | ||
| tau = NULL, | ||
| mode = c("regression", "canonical", "invariant", "classic"), | ||
| scale, | ||
| tol = 1e-06, | ||
| max.iter = 100, | ||
| near.zero.var = FALSE, | ||
| ...){ | ||
| res <- internal_mixOmics( | ||
| X, | ||
| Y, | ||
| indY, | ||
| study, | ||
| ncomp, | ||
| keepX, | ||
| keepY, | ||
| design, | ||
| tau = NULL, | ||
| mode = c("regression", "canonical", "invariant", "classic"), | ||
| scale, | ||
| tol = 1e-06, | ||
| max.iter = 100, | ||
| near.zero.var = FALSE, | ||
| ... | ||
| ) | ||
| return(res) | ||
| } | ||
| ) | ||
|
|
||
| internal_mixOmics <- function(X, |
Author
There was a problem hiding this comment.
The old mixOmics function is converted into generic function. Otherwise I have not touched the existing code
Author
|
Hello @evaham1 ! Is this SE/MAE support something that you could consider? -Tuomas |
Author
|
Hi @dereklei12 ! Is this something that you could consider? -Tuomas |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to this issue: #347
This PR adds support for
SummarizedExperimentandMultiAssayExperimentclasses. They are primary data containers in Bioconductor which is why I think that the support benefits both mixOmics and whole Bioconductor ecosystem.