fix: properly decode UTF-8 from GitHub API base64 content#2
Merged
mkobayashime merged 2 commits intomainfrom Feb 3, 2026
Merged
fix: properly decode UTF-8 from GitHub API base64 content#2mkobayashime merged 2 commits intomainfrom
mkobayashime merged 2 commits intomainfrom
Conversation
The GitHub API returns file content as base64-encoded strings. When using atob() directly, multi-byte UTF-8 characters (like Japanese) were incorrectly decoded as individual Latin-1 characters, causing mojibake in manifest.json name fields. Fix by properly decoding: base64 → binary string → Uint8Array → UTF-8 via TextDecoder. Fixes: #manifest-fenc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
namefields when syncing bookmarks from GitHub repositoriesProblem
The GitHub API returns file content as base64-encoded strings. When using
atob()directly to decode, multi-byte UTF-8 characters (like Japanese text) were incorrectly decoded as individual Latin-1 characters, causing garbled text in bookmark names.Solution
Updated
fetchFileContentinlib/github/api.tsto properly decode UTF-8:atob()Uint8Arrayof bytesTextDecoder()Test plan
manifest.jsoncontaining Japanese (or other multi-byte UTF-8) characters in thenamefield