Skip to content

fix: properly decode UTF-8 from GitHub API base64 content #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkobayashime merged 2 commits into from
Feb 3, 2026
Merged

fix: properly decode UTF-8 from GitHub API base64 content #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af091d5
docs: add task document for manifest encoding issue
mkobayashime Feb 3, 2026
c1b85a8
fix: properly decode UTF-8 from GitHub API base64 content
mkobayashime Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/2026-02-04/manifest-fenc.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
ブックマークの同期において、`manifest.json` の `name` の値が文字化けする問題が発生しています
修正してください
なお `manifest.json` ファイルは UTF-8 エンコーディングされているものとします
8 changes: 7 additions & 1 deletion lib/github/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,13 @@ export const fetchFileContent = async (
const data = (await response.json()) as RepoContent;
if (!data.content) return null;

return atob(data.content);
// Decode base64 to binary string, then convert to Uint8Array, then decode as UTF-8
const binaryString = atob(data.content);
const bytes = new Uint8Array(binaryString.length);
for (let i = 0; i < binaryString.length; i++) {
bytes[i] = binaryString.charCodeAt(i);
}
return new TextDecoder().decode(bytes);
};

/**
Expand Down