refactor: apply for-comprehension to more array-building loops#3446
Closed
refactor: apply for-comprehension to more array-building loops#3446
Conversation
Second follow-up to #3444, extending the same pattern to: - argparse/parser.mbt: group_usage_expr - argparse/parser_lookup.mbt: split_long - env/env_native.mbt: get_cli_args_internal - hashset/hashset.mbt: ToJson impl - set/linked_hash_set.mbt: ToJson impl Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Coverage Report for CI Build 3875Coverage increased (+0.004%) to 94.918%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This was referenced Apr 20, 2026
Contributor
Author
|
Superseded by #3448 which consolidates all comprehension refactors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Third in the series (after #3444 and #3445). Converts five more imperative push-loops to for-comprehensions:
Skipped sites:
Test plan
🤖 Generated with Claude Code