config: don't include valid routingkey and queue (bug 2034672)#93
config: don't include valid routingkey and queue (bug 2034672)#93
Conversation
This is to allow the deployment to set those values, without running the risk of stray stacks reading from legitimate traffic.
| # The exchange is declared by the Producer. | ||
| exchange = "exchange/landoprod/pushes" | ||
| routing_key = "gitpushes" | ||
| routing_key = "SET THIS IN PULSE_ROUTING_KEY ENV VARIABLE" |
There was a problem hiding this comment.
Perhaps we could force this value to be read from the env var instead? ie if the value is missing from the env var there is no fallback to the config file.
There was a problem hiding this comment.
This feels like it may cause some obfuscation of errors, or possibly unexpected errors. Maybe relted to what Connor is saying above? I'd rather avoid having to provide a message inside a value (i.e., we are misusing the variable here...) Either leave this as an empty string or null (if it needs to be defined here) and catch an error elsewhere to show this message, or do not include this here as a value at all.
| # The exchange is declared by the Producer. | ||
| exchange = "exchange/landoprod/pushes" | ||
| routing_key = "gitpushes" | ||
| routing_key = "SET THIS IN PULSE_ROUTING_KEY ENV VARIABLE" |
There was a problem hiding this comment.
This feels like it may cause some obfuscation of errors, or possibly unexpected errors. Maybe relted to what Connor is saying above? I'd rather avoid having to provide a message inside a value (i.e., we are misusing the variable here...) Either leave this as an empty string or null (if it needs to be defined here) and catch an error elsewhere to show this message, or do not include this here as a value at all.
3 participants
This is to allow the deployment to set those values, without running the risk of stray stacks reading from legitimate traffic.
Needs https://github.com/mozilla/webservices-infra/pull/10730 to have landed and be confirmed first.