Skip to content

config: don't include valid routingkey and queue (bug 2034672) #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shtrom wants to merge 1 commit into
base: main
Choose a base branch
from
Open

config: don't include valid routingkey and queue (bug 2034672) #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config-production.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ userid = "SET THIS IN PULSE_USERID ENV VARIABLE"
password = "SET THIS IN PULSE_PASSWORD ENV VARIABLE"
# The exchange is declared by the Producer.
exchange = "exchange/landoprod/pushes"
routing_key = "gitpushes"
routing_key = "SET THIS IN PULSE_ROUTING_KEY ENV VARIABLE"
Copy link
Copy Markdown
Member

@cgsheeh cgsheeh May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could force this value to be read from the env var instead? ie if the value is missing from the env var there is no fallback to the config file.

Copy link
Copy Markdown
Contributor

@zzzeid zzzeid May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like it may cause some obfuscation of errors, or possibly unexpected errors. Maybe relted to what Connor is saying above? I'd rather avoid having to provide a message inside a value (i.e., we are misusing the variable here...) Either leave this as an empty string or null (if it needs to be defined here) and catch an error elsewhere to show this message, or do not include this here as a value at all.

# The Consumer declares the queue and binds it to the exchange.
heartbeat = 30
queue = "queue/githgsyncprod/pushes"
queue = "SET THIS IN PULSE_QUEUE ENV VARIABLE"

[sentry]
sentry_dsn = ""
Expand Down
Loading