Skip to content

Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode#33088

Open
dicarobinho wants to merge 1 commit intomainfrom
afarcasanu/fxios_13321_29001_find_in_page_bar
Open

Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode#33088
dicarobinho wants to merge 1 commit intomainfrom
afarcasanu/fxios_13321_29001_find_in_page_bar

Conversation

@dicarobinho
Copy link
Copy Markdown
Collaborator

📜 Tickets

Jira ticket
Github issue

💡 Description

Manually display keyboard when FF become active

🎥 Demos

ScreenRecording_04-15-2026.10-34-11_1.mp4
Before After
Demo

📝 Checklist

  • I filled in the ticket numbers and a description of my work
  • I updated the PR name to follow our PR naming guidelines
  • I ensured unit tests pass and wrote tests for new code
  • If working on UI, I checked and implemented accessibility (Dynamic Text and VoiceOver)
  • If adding telemetry, I read the data stewardship requirements and will request a data review
  • If adding or modifying strings, I read the guidelines and will request a string review from l10n
  • If needed, I updated documentation and added comments to complex code

@dicarobinho dicarobinho requested a review from thatswinnie April 15, 2026 07:38
@dicarobinho dicarobinho marked this pull request as ready for review April 15, 2026 07:38
@dicarobinho dicarobinho requested a review from a team as a code owner April 15, 2026 07:38
@mobiletest-ci-bot
Copy link
Copy Markdown

Messages
📖 Project coverage: 41.0%

🧹 Tidy commit

Just 2 file(s) touched. Thanks for keeping it clean and review-friendly!

🦊 BrowserViewController Check

We’re tracking the size of BrowserViewController.swift to keep it healthy.

  • ✨ Change in file size: +5 lines

✅ New file code coverage

No new file detected so code coverage gate wasn't ran.

Client.app: Coverage: 39.4

File Coverage
BrowserViewController.swift 34.46% ⚠️
BrowserViewController+FindInPage.swift 8.93% ⚠️

Generated by 🚫 Danger Swift against 7566ef6

@thatswinnie
Copy link
Copy Markdown
Collaborator

While this seems to work, I would prefer if we look for the root cause: why is the keyboard getting dismissed in private mode but not in normal mode?

@dicarobinho
Copy link
Copy Markdown
Collaborator Author

On iOS 16+, we are using native findNavigator from webView. Safari have the same behaviour in private mode. We can "avoid" that by re-displaying findNavigator.

@thatswinnie
Copy link
Copy Markdown
Collaborator

On iOS 16+, we are using native findNavigator from webView. Safari have the same behaviour in private mode. We can "avoid" that by re-displaying findNavigator.

It works in Safari because they are hiding the toolbars when Find in Page is active. I think instead of trying to bring the keyboard back up we should do the same: hide the toolbars when Find in Page is getting selected and bring them back when Find in Page is off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants