Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode#33088
Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode#33088dicarobinho wants to merge 1 commit intomainfrom
Conversation
… in private mode
🧹 Tidy commitJust 2 file(s) touched. Thanks for keeping it clean and review-friendly! 🦊 BrowserViewController CheckWe’re tracking the size of
✅ New file code coverageNo new file detected so code coverage gate wasn't ran. Client.app: Coverage: 39.4
Generated by 🚫 Danger Swift against 7566ef6 |
|
While this seems to work, I would prefer if we look for the root cause: why is the keyboard getting dismissed in private mode but not in normal mode? |
|
On iOS 16+, we are using native findNavigator from webView. Safari have the same behaviour in private mode. We can "avoid" that by re-displaying findNavigator. |
It works in Safari because they are hiding the toolbars when Find in Page is active. I think instead of trying to bring the keyboard back up we should do the same: hide the toolbars when Find in Page is getting selected and bring them back when Find in Page is off. |
📜 Tickets
Jira ticket
Github issue
💡 Description
Manually display keyboard when FF become active
🎥 Demos
ScreenRecording_04-15-2026.10-34-11_1.mp4
Demo
📝 Checklist