Skip to content

Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode #33088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dicarobinho wants to merge 1 commit into
base: main
Choose a base branch
from
+15 −0
Open

Bugfix FXIOS-13321 ⁃ [iOS 26] - Find in page bar has a weird behavior in private mode #33088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .../Frontend/Browser/BrowserViewController/Extensions/BrowserViewController+FindInPage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,16 @@ extension BrowserViewController {
}
}

@available(iOS 16, *)
func restoreFindInPageIfNeeded() {
guard let tab = tabManager.selectedTab,
tab.isPrivate,
tab.isFindInPageMode,
let webView = tab.webView else { return }

webView.findInteraction?.presentFindNavigator(showingReplace: false)
}

// Used only on iOS 15
private func useCustomFindInteraction(isVisible: Bool, tab: Tab? = nil) {
if isVisible {
Expand Down
5 changes: 5 additions & 0 deletions firefox-ios/Client/Frontend/Browser/BrowserViewController/Views/BrowserViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -896,6 +896,11 @@ class BrowserViewController: UIViewController,
scrollController.showToolbars(animated: false)
}

// In some cases (see restoreFindInPageIfNeeded) is necessary to display manually find in page bar
if #available(iOS 16, *) {
restoreFindInPageIfNeeded()
}

navigationHandler?.showTermsOfUse(context: .appBecameActive)
browserDidBecomeActive()
}
Expand Down
Loading