PassNode: Fix depthTexture creation when depthBuffer: false#33239
Open
thelazylamaGit wants to merge 3 commits intomrdoob:devfrom
Open
PassNode: Fix depthTexture creation when depthBuffer: false#33239thelazylamaGit wants to merge 3 commits intomrdoob:devfrom
depthBuffer: false#33239thelazylamaGit wants to merge 3 commits intomrdoob:devfrom
Conversation
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With
PassNodea depth texture was always being created even when explicitly setting{ depthBuffer: false }.Additonally,
Textures.updateRenderTarget()also handled depth before checking whether it was actually enabled. Because of that, a depth texture could end up being created even with depth disabled.This pr ensures that when creating a pass such as
no depth texture is created.